refactor: clean up api/error.ts (#4542)

jsjoeio · web-flow · commit b1409831a32f · 2022-10-14T09:09:09.000-03:00
This removes an eslint-disable lint and updates the `err` type to
`unknown` instead of `any` which is more correct.
diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
@@ -23,8 +23,7 @@ export type ApiError = AxiosError<ApiErrorResponse> & {
   response: AxiosResponse<ApiErrorResponse>
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any
-export const isApiError = (err: any): err is ApiError => {
+export const isApiError = (err: unknown): err is ApiError => {
   if (axios.isAxiosError(err)) {
     const response = err.response?.data
     if (!response) {

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,7 @@ export type ApiError = AxiosError<ApiErrorResponse> & {`
`23`	`23`	`response: AxiosResponse<ApiErrorResponse>`
`24`	`24`	`}`
`25`	`25`
`26`		`-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any`
`27`		`-export const isApiError = (err: any): err is ApiError => {`
	`26`	`+export const isApiError = (err: unknown): err is ApiError => {`
`28`	`27`	`if (axios.isAxiosError(err)) {`
`29`	`28`	`const response = err.response?.data`
`30`	`29`	`if (!response) {`