fix: order provisioner keys by creation date (#15125)

f0ssel · web-flow · commit b54950cc6e90 · 2024-10-17T13:57:52.000-04:00
Closes coder/internal#110 The flake reported in the issue has already been fixed by #14875, but this further covers that we return a list the same order every time.
diff --git a/enterprise/coderd/provisionerkeys.go b/enterprise/coderd/provisionerkeys.go
@@ -212,5 +212,10 @@ func convertProvisionerKeys(dbKeys []database.ProvisionerKey) []codersdk.Provisi
 			// HashedSecret - never include the access token in the API response
 		})
 	}
+
+	slices.SortFunc(keys, func(key1, key2 codersdk.ProvisionerKey) int {
+		return key1.CreatedAt.Compare(key2.CreatedAt)
+	})
+
 	return keys
 }

Original file line number	Diff line number	Diff line change
`@@ -212,5 +212,10 @@ func convertProvisionerKeys(dbKeys []database.ProvisionerKey) []codersdk.Provisi`
`212`	`212`	`// HashedSecret - never include the access token in the API response`
`213`	`213`	`})`
`214`	`214`	`}`
	`215`	`+`
	`216`	`+ slices.SortFunc(keys, func(key1, key2 codersdk.ProvisionerKey) int {`
	`217`	`+ return key1.CreatedAt.Compare(key2.CreatedAt)`
	`218`	`+ })`
	`219`	`+`
`215`	`220`	`return keys`
`216`	`221`	`}`