test(coderd/database/pubsub): ensure db closure on unhappy paths (#16327)

mafredri · web-flow · commit b77b5432c6e4 · 2025-01-29T14:47:38.000Z
diff --git a/coderd/database/pubsub/pubsub_linux_test.go b/coderd/database/pubsub/pubsub_linux_test.go
@@ -305,6 +305,9 @@ func TestMeasureLatency(t *testing.T) {
 		require.NoError(t, err)
 		db, err := sql.Open("postgres", connectionURL)
 		require.NoError(t, err)
+		t.Cleanup(func() {
+			_ = db.Close()
+		})
 		ps, err := pubsub.New(ctx, logger, db, connectionURL)
 		require.NoError(t, err)
 
diff --git a/coderd/database/pubsub/pubsub_test.go b/coderd/database/pubsub/pubsub_test.go
@@ -137,6 +137,7 @@ func TestPGPubsubDriver(t *testing.T) {
 	// use a separate subber and pubber so we can keep track of listener connections
 	db, err := sql.Open("postgres", connectionURL)
 	require.NoError(t, err)
+	defer db.Close()
 	pubber, err := pubsub.New(ctx, logger, db, connectionURL)
 	require.NoError(t, err)
 	defer pubber.Close()
@@ -147,6 +148,7 @@ func TestPGPubsubDriver(t *testing.T) {
 	tconn, err := subDriver.Connector(connectionURL)
 	require.NoError(t, err)
 	tcdb := sql.OpenDB(tconn)
+	defer tcdb.Close()
 	subber, err := pubsub.New(ctx, logger, tcdb, connectionURL)
 	require.NoError(t, err)
 	defer subber.Close()
