Skip to content

Commit bf63cc9

Browse files
fix: Fix audit search query (#4352)
1 parent 1d88b9c commit bf63cc9

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

coderd/audit.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,18 +265,23 @@ func auditSearchQuery(query string) (database.GetAuditLogsOffsetParams, []coders
265265
Username: parser.String(searchParams, "", "username"),
266266
Email: parser.String(searchParams, "", "email"),
267267
}
268-
269268
return filter, parser.Errors
270269
}
271270

272271
func resourceTypeFromString(resourceTypeString string) string {
273272
switch codersdk.ResourceType(resourceTypeString) {
274273
case codersdk.ResourceTypeOrganization:
274+
return resourceTypeString
275275
case codersdk.ResourceTypeTemplate:
276+
return resourceTypeString
276277
case codersdk.ResourceTypeTemplateVersion:
278+
return resourceTypeString
277279
case codersdk.ResourceTypeUser:
280+
return resourceTypeString
278281
case codersdk.ResourceTypeWorkspace:
282+
return resourceTypeString
279283
case codersdk.ResourceTypeGitSSHKey:
284+
return resourceTypeString
280285
case codersdk.ResourceTypeAPIKey:
281286
return resourceTypeString
282287
}
@@ -286,10 +291,11 @@ func resourceTypeFromString(resourceTypeString string) string {
286291
func actionFromString(actionString string) string {
287292
switch codersdk.AuditAction(actionString) {
288293
case codersdk.AuditActionCreate:
294+
return actionString
289295
case codersdk.AuditActionWrite:
296+
return actionString
290297
case codersdk.AuditActionDelete:
291298
return actionString
292-
default:
293299
}
294300
return ""
295301
}

coderd/audit_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ func TestAuditLogsFilter(t *testing.T) {
130130
}
131131

132132
for _, testCase := range testCases {
133+
testCase := testCase
133134
// Test filtering
134135
t.Run(testCase.Name, func(t *testing.T) {
135136
t.Parallel()

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy