fix: log unsuccessful webhook response body as a string (#16439)

aaronlehmann · web-flow · commit c8ef7eb4f2a9 · 2025-02-05T13:22:20.000+02:00
diff --git a/coderd/notifications/dispatch/webhook.go b/coderd/notifications/dispatch/webhook.go
@@ -106,7 +106,7 @@ func (w *WebhookHandler) dispatch(msgPayload types.MessagePayload, titlePlaintex
 				return true, xerrors.Errorf("non-2xx response (%d), read body: %w", resp.StatusCode, err)
 			}
 			w.log.Warn(ctx, "unsuccessful delivery", slog.F("status_code", resp.StatusCode),
-				slog.F("response", respBody[:n]), slog.F("msg_id", msgID))
+				slog.F("response", string(respBody[:n])), slog.F("msg_id", msgID))
 			return true, xerrors.Errorf("non-2xx response (%d)", resp.StatusCode)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func (w *WebhookHandler) dispatch(msgPayload types.MessagePayload, titlePlaintex`
`106`	`106`	`return true, xerrors.Errorf("non-2xx response (%d), read body: %w", resp.StatusCode, err)`
`107`	`107`	`}`
`108`	`108`	`w.log.Warn(ctx, "unsuccessful delivery", slog.F("status_code", resp.StatusCode),`
`109`		`- slog.F("response", respBody[:n]), slog.F("msg_id", msgID))`
	`109`	`+ slog.F("response", string(respBody[:n])), slog.F("msg_id", msgID))`
`110`	`110`	`return true, xerrors.Errorf("non-2xx response (%d)", resp.StatusCode)`
`111`	`111`	`}`
`112`	`112`