fix: Increase randomness for names used in tests (#3063)

mafredri · web-flow · commit cd74afcccc10 · 2022-07-20T18:03:04.000+03:00
We are starting to run into test flakes due to lack of randomness in CI, this change simply bumps randomness by additional suffix numbers. See: #3038 (comment)
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -271,7 +271,7 @@ func CreateAnotherUser(t *testing.T, client *codersdk.Client, organizationID uui
 
 func createAnotherUserRetry(t *testing.T, client *codersdk.Client, organizationID uuid.UUID, retries int, roles ...string) *codersdk.Client {
 	req := codersdk.CreateUserRequest{
-		Email:          namesgenerator.GetRandomName(1) + "@coder.com",
+		Email:          namesgenerator.GetRandomName(10) + "@coder.com",
 		Username:       randomUsername(),
 		Password:       "testpass",
 		OrganizationID: organizationID,
@@ -677,7 +677,7 @@ func NewAzureInstanceIdentity(t *testing.T, instanceID string) (x509.VerifyOptio
 }
 
 func randomUsername() string {
-	return strings.ReplaceAll(namesgenerator.GetRandomName(0), "_", "-")
+	return strings.ReplaceAll(namesgenerator.GetRandomName(10), "_", "-")
 }
 
 // Used to easily create an HTTP transport!

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ func CreateAnotherUser(t testing.T, client codersdk.Client, organizationID uui`
`271`	`271`
`272`	`272`	`func createAnotherUserRetry(t testing.T, client codersdk.Client, organizationID uuid.UUID, retries int, roles ...string) *codersdk.Client {`
`273`	`273`	`req := codersdk.CreateUserRequest{`
`274`		`- Email: namesgenerator.GetRandomName(1) + "@coder.com",`
	`274`	`+ Email: namesgenerator.GetRandomName(10) + "@coder.com",`
`275`	`275`	`Username: randomUsername(),`
`276`	`276`	`Password: "testpass",`
`277`	`277`	`OrganizationID: organizationID,`
`@@ -677,7 +677,7 @@ func NewAzureInstanceIdentity(t *testing.T, instanceID string) (x509.VerifyOptio`
`677`	`677`	`}`
`678`	`678`
`679`	`679`	`func randomUsername() string {`
`680`		`- return strings.ReplaceAll(namesgenerator.GetRandomName(0), "_", "-")`
	`680`	`+ return strings.ReplaceAll(namesgenerator.GetRandomName(10), "_", "-")`
`681`	`681`	`}`
`682`	`682`
`683`	`683`	`// Used to easily create an HTTP transport!`