fix: remove filters

jaaydenh · jaaydenh · commit dd5147d1478f · 2025-04-11T20:53:44.000Z
diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -174,10 +174,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					</SelectTrigger>
 					<SelectContent>
 						{parameter.options
-							.filter(
-								(option): option is NonNullable<typeof option> =>
-									option !== null,
-							)
 							.map((option) => (
 								<SelectItem key={option.value.value} value={option.value.value}>
 									<OptionDisplay option={option} />
@@ -190,7 +186,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
 		case "multi-select": {
 			// Map parameter options to MultiSelectCombobox options format
 			const comboboxOptions: Option[] = parameter.options
-				.filter((opt): opt is NonNullable<typeof opt> => opt !== null)
 				.map((opt) => ({
 					value: opt.value.value,
 					label: opt.name,
@@ -200,7 +195,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			const defaultOptions: Option[] = JSON.parse(defaultValue).map(
 				(val: string) => {
 					const option = parameter.options
-						.filter((o): o is NonNullable<typeof o> => o !== null)
 						.find((o) => o.value.value === val);
 					return {
 						value: val,
@@ -252,9 +246,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					defaultValue={defaultValue}
 				>
 					{parameter.options
-						.filter(
-							(option): option is NonNullable<typeof option> => option !== null,
-						)
 						.map((option) => (
 							<div
 								key={option.value.value}
@@ -294,10 +285,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			const inputProps: Record<string, unknown> = {};
 
 			if (parameter.type === "number") {
-				const validations =
-					parameter.validations.filter(
-						(v): v is NonNullable<typeof v> => v !== null,
-					)[0] || {};
+				const validations = parameter.validations[0] || {};
 				const { validation_min, validation_max } = validations;
 
 				if (validation_min !== null) {
@@ -366,10 +354,6 @@ const ParameterDiagnostics: FC<ParameterDiagnosticsProps> = ({
 	return (
 		<div className="flex flex-col gap-2">
 			{diagnostics
-				.filter(
-					(diagnostic): diagnostic is NonNullable<typeof diagnostic> =>
-						diagnostic !== null,
-				)
 				.map((diagnostic, index) => (
 					<div
 						key={`diagnostic-${diagnostic.summary}-${index}`}
@@ -425,7 +409,6 @@ const isValidValue = (
 ) => {
 	if (previewParam.options.length > 0) {
 		const validValues = previewParam.options
-			.filter((option): option is NonNullable<typeof option> => option !== null)
 			.map((option) => option.value.value);
 		return validValues.includes(buildParam.value);
 	}
@@ -455,10 +438,8 @@ export const useValidationSchemaForDynamicParameters = (
 							switch (parameter.type) {
 								case "number": {
 									const minValidation = parameter.validations
-										.filter((v): v is NonNullable<typeof v> => v !== null)
 										.find((v) => v.validation_min !== null);
 									const maxValidation = parameter.validations
-										.filter((v): v is NonNullable<typeof v> => v !== null)
 										.find((v) => v.validation_max !== null);
 
 									if (
@@ -506,7 +487,6 @@ export const useValidationSchemaForDynamicParameters = (
 									}
 
 									const monotonic = parameter.validations
-										.filter((v): v is NonNullable<typeof v> => v !== null)
 										.find(
 											(v) =>
 												v.validation_monotonic !== null &&
@@ -542,7 +522,6 @@ export const useValidationSchemaForDynamicParameters = (
 								}
 								case "string": {
 									const regex = parameter.validations
-										.filter((v): v is NonNullable<typeof v> => v !== null)
 										.find(
 											(v) =>
 												v.validation_regex !== null &&
@@ -574,13 +553,10 @@ const parameterError = (
 	value?: string,
 ): string | undefined => {
 	const validation_error = parameter.validations
-		.filter((v): v is NonNullable<typeof v> => v !== null)
 		.find((v) => v.validation_error !== null);
 	const minValidation = parameter.validations
-		.filter((v): v is NonNullable<typeof v> => v !== null)
 		.find((v) => v.validation_min !== null);
 	const maxValidation = parameter.validations
-		.filter((v): v is NonNullable<typeof v> => v !== null)
 		.find((v) => v.validation_max !== null);
 
 	if (!validation_error || !value) {
