improve errors handling

defelmnq · defelmnq · commit de9e73aab832 · 2025-01-27T11:33:15.000Z
diff --git a/coderd/provisionerdserver/acquirer_test.go b/coderd/provisionerdserver/acquirer_test.go
@@ -548,7 +548,7 @@ func TestAcquirer_MatchTags(t *testing.T) {
 			lines = append(lines, s)
 		}
 		t.Logf("You can paste this into docs/admin/provisioners.md")
-		t.Logf(strings.Join(lines, "\n"))
+		t.Log("%s", strings.Join(lines, "\n"))
 	})
 }
 
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1929,13 +1929,16 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
 
 		if prAgent.ResourcesMonitoring != nil {
 			if prAgent.ResourcesMonitoring.Memory != nil {
-				db.InsertWorkspaceAgentResourceMonitor(ctx, database.InsertWorkspaceAgentResourceMonitorParams{
+				_, err = db.InsertWorkspaceAgentResourceMonitor(ctx, database.InsertWorkspaceAgentResourceMonitorParams{
 					AgentID:   agentID,
 					Rtype:     database.WorkspaceAgentMonitoredResourceTypeMemory,
 					Enabled:   prAgent.ResourcesMonitoring.Memory.Enabled,
 					Threshold: prAgent.ResourcesMonitoring.Memory.Threshold,
 					CreatedAt: dbtime.Now(),
 				})
+				if err != nil {
+					return xerrors.Errorf("insert agent resource monitor: %w", err)
+				}
 			}
 
 			for volume, monitor := range prAgent.ResourcesMonitoring.Volumes {
@@ -1946,14 +1949,17 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
 					return xerrors.Errorf("marshal metadata: %w", err)
 				}
 
-				db.InsertWorkspaceAgentResourceMonitor(ctx, database.InsertWorkspaceAgentResourceMonitorParams{
+				_, err = db.InsertWorkspaceAgentResourceMonitor(ctx, database.InsertWorkspaceAgentResourceMonitorParams{
 					AgentID:   agentID,
 					Rtype:     database.WorkspaceAgentMonitoredResourceTypeVolume,
 					Enabled:   monitor.Enabled,
 					Threshold: monitor.Threshold,
 					Metadata:  marshaledMetadata,
 					CreatedAt: dbtime.Now(),
 				})
+				if err != nil {
+					return xerrors.Errorf("insert agent resource monitor: %w", err)
+				}
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,7 @@ func TestAcquirer_MatchTags(t *testing.T) {`
`548`	`548`	`lines = append(lines, s)`
`549`	`549`	`}`
`550`	`550`	`t.Logf("You can paste this into docs/admin/provisioners.md")`
`551`		`- t.Logf(strings.Join(lines, "\n"))`
	`551`	`+ t.Log("%s", strings.Join(lines, "\n"))`
`552`	`552`	`})`
`553`	`553`	`}`
`554`	`554`