fix bugs

evgeniy-scherbina · evgeniy-scherbina · commit f973ca6ac90e · 2025-06-02T13:06:07.000Z
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -2268,7 +2268,10 @@ func (q *querier) GetPresetParametersByTemplateVersionID(ctx context.Context, ar
 }
 
 func (q *querier) GetPresetPrebuildSchedules(ctx context.Context) ([]database.TemplateVersionPresetPrebuildSchedule, error) {
-	panic("not implemented")
+	if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceTemplate.All()); err != nil {
+		return nil, err
+	}
+	return q.db.GetPresetPrebuildSchedules(ctx)
 }
 
 func (q *querier) GetPresetsAtFailureLimit(ctx context.Context, hardLimit int64) ([]database.GetPresetsAtFailureLimitRow, error) {
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
diff --git a/coderd/prebuilds/global_snapshot.go b/coderd/prebuilds/global_snapshot.go
@@ -1,6 +1,8 @@
 package prebuilds
 
 import (
+	"encoding/json"
+	"fmt"
 	"time"
 
 	"github.com/google/uuid"
@@ -51,10 +53,19 @@ func (s GlobalSnapshot) FilterByPreset(presetID uuid.UUID) (*PresetSnapshot, err
 		return nil, xerrors.Errorf("no preset found with ID %q", presetID)
 	}
 
-	prebuildSchedules := slice.Filter(s.PrebuildSchedules, func(preset database.TemplateVersionPresetPrebuildSchedule) bool {
-		return preset.ID == presetID
+	globalPrebuildSchedulesInJSON, err := json.Marshal(s.PrebuildSchedules)
+	if err != nil {
+		return nil, err
+	}
+	prebuildSchedules := slice.Filter(s.PrebuildSchedules, func(schedule database.TemplateVersionPresetPrebuildSchedule) bool {
+		return schedule.PresetID == presetID
 	})
 
+	localPrebuildSchedulesInJSON, err := json.Marshal(prebuildSchedules)
+	if err != nil {
+		return nil, err
+	}
+	q
 	// Only include workspaces that have successfully started
 	running := slice.Filter(s.RunningPrebuilds, func(prebuild database.GetRunningPrebuiltWorkspacesRow) bool {
 		if !prebuild.CurrentPresetID.Valid {
diff --git a/coderd/prebuilds/preset_snapshot.go b/coderd/prebuilds/preset_snapshot.go
@@ -151,7 +151,8 @@ func (p PresetSnapshot) CalculateState() *ReconciliationState {
 	expired = int32(len(p.Expired))
 
 	if p.isActive() {
-		desired, err := p.calculateDesiredInstances(time.Now())
+		var err error
+		desired, err = p.calculateDesiredInstances(time.Now())
 		if err != nil {
 			// TODO: handle error
 		}

Original file line number	Diff line number	Diff line change
`@@ -2268,7 +2268,10 @@ func (q *querier) GetPresetParametersByTemplateVersionID(ctx context.Context, ar`
`2268`	`2268`	`}`
`2269`	`2269`
`2270`	`2270`	`func (q *querier) GetPresetPrebuildSchedules(ctx context.Context) ([]database.TemplateVersionPresetPrebuildSchedule, error) {`
`2271`		`- panic("not implemented")`
	`2271`	`+ if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceTemplate.All()); err != nil {`
	`2272`	`+ return nil, err`
	`2273`	`+ }`
	`2274`	`+ return q.db.GetPresetPrebuildSchedules(ctx)`
`2272`	`2275`	`}`
`2273`	`2276`
`2274`	`2277`	`func (q *querier) GetPresetsAtFailureLimit(ctx context.Context, hardLimit int64) ([]database.GetPresetsAtFailureLimitRow, error) {`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,8 @@ func (p PresetSnapshot) CalculateState() *ReconciliationState {`
`151`	`151`	`expired = int32(len(p.Expired))`
`152`	`152`
`153`	`153`	`if p.isActive() {`
`154`		`- desired, err := p.calculateDesiredInstances(time.Now())`
	`154`	`+ var err error`
	`155`	`+ desired, err = p.calculateDesiredInstances(time.Now())`
`155`	`156`	`if err != nil {`
`156`	`157`	`// TODO: handle error`
`157`	`158`	`}`