fix: Don't fetch resources when a workspace is building

kylecarbs · kylecarbs · commit fde1fb4fce4d · 2022-08-09T13:32:42.000Z
Fixes #3423.
diff --git a/site/src/xServices/workspace/workspaceXService.ts b/site/src/xServices/workspace/workspaceXService.ts
@@ -550,12 +550,13 @@ export const workspaceMachine = createMachine(
         }
       },
       getResources: async (context) => {
-        if (context.workspace) {
-          const resources = await API.getWorkspaceResources(context.workspace.latest_build.id)
-          return resources
-        } else {
-          throw Error("Cannot fetch workspace resources without workspace")
+        // If the job hasn't completed, fetching resources will result
+        // in an unfriendly error for the user.
+        if (!context.workspace?.latest_build.job.completed_at) {
+          return []
         }
+        const resources = await API.getWorkspaceResources(context.workspace.latest_build.id)
+        return resources
       },
       getBuilds: async (context) => {
         if (context.workspace) {
