Skip to content

Commit ff8d3de

Browse files
dannykoppingdannykopping
committed
Merge branch 'main' of github.com:/coder/coder into yevhenii/512-claim-prebuild
2 parents b246589 + 0ef7d0b commit ff8d3de

File tree

96 files changed

+1964
-107
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+1964
-107
lines changed

‎agent/ls.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,14 @@ func listFiles(query LSRequest) (LSResponse, error) {
125125
}
126126

127127
func listDrives() (LSResponse, error) {
128+
// disk.Partitions() will return partitions even if there was a failure to
129+
// get one. Any errored partitions will not be returned.
128130
partitionStats, err := disk.Partitions(true)
129-
if err != nil {
131+
if err != nil && len(partitionStats) == 0 {
132+
// Only return the error if there were no partitions returned.
130133
return LSResponse{}, xerrors.Errorf("failed to get partitions: %w", err)
131134
}
135+
132136
contents := make([]LSFile, 0, len(partitionStats))
133137
for _, a := range partitionStats {
134138
// Drive letters on Windows have a trailing separator as part of their name.

‎cli/server.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2160,6 +2160,8 @@ func startBuiltinPostgres(ctx context.Context, cfg config.Root, logger slog.Logg
21602160
embeddedpostgres.DefaultConfig().
21612161
Version(embeddedpostgres.V13).
21622162
BinariesPath(filepath.Join(cfg.PostgresPath(), "bin")).
2163+
// Default BinaryRepositoryURL repo1.maven.org is flaky.
2164+
BinaryRepositoryURL("https://repo.maven.apache.org/maven2").
21632165
DataPath(filepath.Join(cfg.PostgresPath(), "data")).
21642166
RuntimePath(filepath.Join(cfg.PostgresPath(), "runtime")).
21652167
CachePath(cachePath).

‎coderd/coderd.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1819,10 +1819,10 @@ func ReadExperiments(log slog.Logger, raw []string) codersdk.Experiments {
18191819
for _, v := range raw {
18201820
switch v {
18211821
case "*":
1822-
exps = append(exps, codersdk.ExperimentsAll...)
1822+
exps = append(exps, codersdk.ExperimentsSafe...)
18231823
default:
18241824
ex := codersdk.Experiment(strings.ToLower(v))
1825-
if !slice.Contains(codersdk.ExperimentsAll, ex) {
1825+
if !slice.Contains(codersdk.ExperimentsSafe, ex) {
18261826
log.Warn(context.Background(), "🐉 HERE BE DRAGONS: opting into hidden experiment", slog.F("experiment", ex))
18271827
}
18281828
exps = append(exps, ex)

‎coderd/experiments.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@ func (api *API) handleExperimentsGet(rw http.ResponseWriter, r *http.Request) {
2929
func handleExperimentsSafe(rw http.ResponseWriter, r *http.Request) {
3030
ctx := r.Context()
3131
httpapi.Write(ctx, rw, http.StatusOK, codersdk.AvailableExperiments{
32-
Safe: codersdk.ExperimentsAll,
32+
Safe: codersdk.ExperimentsSafe,
3333
})
3434
}

‎coderd/experiments_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ func Test_Experiments(t *testing.T) {
6969
experiments, err := client.Experiments(ctx)
7070
require.NoError(t, err)
7171
require.NotNil(t, experiments)
72-
require.ElementsMatch(t, codersdk.ExperimentsAll, experiments)
73-
for _, ex := range codersdk.ExperimentsAll {
72+
require.ElementsMatch(t, codersdk.ExperimentsSafe, experiments)
73+
for _, ex := range codersdk.ExperimentsSafe {
7474
require.True(t, experiments.Enabled(ex))
7575
}
7676
require.False(t, experiments.Enabled("danger"))
@@ -91,8 +91,8 @@ func Test_Experiments(t *testing.T) {
9191
experiments, err := client.Experiments(ctx)
9292
require.NoError(t, err)
9393
require.NotNil(t, experiments)
94-
require.ElementsMatch(t, append(codersdk.ExperimentsAll, "danger"), experiments)
95-
for _, ex := range codersdk.ExperimentsAll {
94+
require.ElementsMatch(t, append(codersdk.ExperimentsSafe, "danger"), experiments)
95+
for _, ex := range codersdk.ExperimentsSafe {
9696
require.True(t, experiments.Enabled(ex))
9797
}
9898
require.True(t, experiments.Enabled("danger"))
@@ -131,6 +131,6 @@ func Test_Experiments(t *testing.T) {
131131
experiments, err := client.SafeExperiments(ctx)
132132
require.NoError(t, err)
133133
require.NotNil(t, experiments)
134-
require.ElementsMatch(t, codersdk.ExperimentsAll, experiments.Safe)
134+
require.ElementsMatch(t, codersdk.ExperimentsSafe, experiments.Safe)
135135
})
136136
}

‎coderd/prometheusmetrics/prometheusmetrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ func Experiments(registerer prometheus.Registerer, active codersdk.Experiments)
655655
return err
656656
}
657657

658-
for _, exp := range codersdk.ExperimentsAll {
658+
for _, exp := range codersdk.ExperimentsSafe {
659659
var val float64
660660
for _, enabled := range active {
661661
if exp == enabled {

‎coderd/prometheusmetrics/prometheusmetrics_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ func TestAgentStats(t *testing.T) {
612612
func TestExperimentsMetric(t *testing.T) {
613613
t.Parallel()
614614

615-
if len(codersdk.ExperimentsAll) == 0 {
615+
if len(codersdk.ExperimentsSafe) == 0 {
616616
t.Skip("No experiments are currently defined; skipping test.")
617617
}
618618

@@ -624,17 +624,17 @@ func TestExperimentsMetric(t *testing.T) {
624624
{
625625
name: "Enabled experiment is exported in metrics",
626626
experiments: codersdk.Experiments{
627-
codersdk.ExperimentsAll[0],
627+
codersdk.ExperimentsSafe[0],
628628
},
629629
expected: map[codersdk.Experiment]float64{
630-
codersdk.ExperimentsAll[0]: 1,
630+
codersdk.ExperimentsSafe[0]: 1,
631631
},
632632
},
633633
{
634634
name: "Disabled experiment is exported in metrics",
635635
experiments: codersdk.Experiments{},
636636
expected: map[codersdk.Experiment]float64{
637-
codersdk.ExperimentsAll[0]: 0,
637+
codersdk.ExperimentsSafe[0]: 0,
638638
},
639639
},
640640
{

‎codersdk/deployment.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3258,11 +3258,11 @@ const (
32583258
ExperimentDynamicParameters Experiment = "dynamic-parameters" // Enables dynamic parameters when creating a workspace.
32593259
)
32603260

3261-
// ExperimentsAll should include all experiments that are safe for
3261+
// ExperimentsSafe should include all experiments that are safe for
32623262
// users to opt-in to via --experimental='*'.
32633263
// Experiments that are not ready for consumption by all users should
32643264
// not be included here and will be essentially hidden.
3265-
var ExperimentsAll = Experiments{}
3265+
var ExperimentsSafe = Experiments{}
32663266

32673267
// Experiments is a list of experiments.
32683268
// Multiple experiments may be enabled at the same time.

‎docs/admin/networking/troubleshooting.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,27 @@ the NAT configuration, or deploy an internal STUN server.
9595

9696
If a network interface on the side of either the client or agent has an MTU
9797
smaller than 1378, any direct connections form may have degraded quality or
98-
performance, as IP packets are fragmented. `coder ping` will indicate if this is
99-
the case by inspecting network interfaces on both the client and the workspace
100-
agent.
98+
might hang entirely.
10199

102-
If another interface cannot be used, and the MTU cannot be changed, you may need
103-
to disable direct connections, and relay all traffic via DERP instead, which
100+
Use `coder ping` to check for MTU issues, as it inspects
101+
network interfaces on both the client and the workspace agent:
102+
103+
```console
104+
$ coder ping my-workspace
105+
...
106+
Possible client-side issues with direct connection:
107+
108+
- Network interface utun0 has MTU 1280 (less than 1378), which may degrade the quality of direct connections or render them unusable.
109+
```
110+
111+
If another interface cannot be used, and the MTU cannot be changed, you should
112+
disable direct connections and relay all traffic via DERP instead, which
104113
will not be affected by the low MTU.
105114

115+
To disable direct connections, set the
116+
[`--block-direct-connections`](../../reference/cli/server.md#--block-direct-connections)
117+
flag or `CODER_BLOCK_DIRECT` environment variable on the Coder server.
118+
106119
## Throughput
107120

108121
The `coder speedtest <workspace>` command measures the throughput between the

‎go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ replace github.com/tcnksm/go-httpstat => github.com/coder/go-httpstat v0.0.0-202
3636

3737
// There are a few minor changes we make to Tailscale that we're slowly upstreaming. Compare here:
3838
// https://github.com/tailscale/tailscale/compare/main...coder:tailscale:main
39-
replace tailscale.com => github.com/coder/tailscale v1.1.1-0.20250410041146-e62bfe0e9301
39+
replace tailscale.com => github.com/coder/tailscale v1.1.1-0.20250422090654-5090e715905e
4040

4141
// This is replaced to include
4242
// 1. a fix for a data race: c.f. https://github.com/tailscale/wireguard-go/pull/25
@@ -102,7 +102,7 @@ require (
102102
github.com/coder/quartz v0.1.2
103103
github.com/coder/retry v1.5.1
104104
github.com/coder/serpent v0.10.0
105-
github.com/coder/terraform-provider-coder/v2 v2.4.0-pre1
105+
github.com/coder/terraform-provider-coder/v2 v2.4.0-pre1.0.20250417100258-c86bb5c3ddcd
106106
github.com/coder/websocket v1.8.13
107107
github.com/coder/wgtunnel v0.1.13-0.20240522110300-ade90dfb2da0
108108
github.com/coreos/go-oidc/v3 v3.14.1
@@ -488,7 +488,7 @@ require (
488488
)
489489

490490
require (
491-
github.com/coder/preview v0.0.0-20250417203026-7edcb9e02d99
491+
github.com/coder/preview v0.0.1
492492
github.com/kylecarbs/aisdk-go v0.0.5
493493
github.com/mark3labs/mcp-go v0.22.0
494494
)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy