Skip to content

CODER_NOTIFICATIONS_EMAIL_SMARTHOST's value is never used #15480

@dannykopping

Description

@dannykopping

CODER_NOTIFICATIONS_EMAIL_SMARTHOST is now deprecated, and superseded by CODER_EMAIL_SMARTHOST in #15270.

However, if CODER_EMAIL_SMARTHOST is unset then the value from CODER_NOTIFICATIONS_EMAIL_SMARTHOST should be used. Currently it is not, and I suspect it's because CODER_EMAIL_SMARTHOST has a default value:

	emailSmarthost := serpent.Option{
		Name:        "Email: Smarthost",
		Description: "The intermediary SMTP host through which emails are sent.",
		Flag:        "email-smarthost",
		Env:         "CODER_EMAIL_SMARTHOST",
		Default:     "localhost:587", // To pass validation.
		Value:       &c.Notifications.SMTP.Smarthost,
		Group:       &deploymentGroupEmail,
		YAML:        "smarthost",
	}

Metadata

Metadata

Labels

bug riskProne to bugsneeds-triageIssue that require triages2Broken use cases or features (with a workaround). Only humans may set this.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy