bug: CODER_OAUTH2_GITHUB_ALLOWED_ORGS breaks first login via GitHub #17752
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
2025-05-09.22-23-40.mp4
When setting CODER_OAUTH2_GITHUB_ALLOWED_ORGS on a fresh Coder deployment, the Coder deployment will try to check against the orgs list, but since the built-in Coder GitHub app does not set that permission, Coder will just think that you're not a member of the org.
Relevant Log Output
Expected Behavior
Coder should ignore CODER_OAUTH2_GITHUB_ALLOWED_ORGS, or should be using the OAuth app with ID github (or the first with github type) if defined by the admin, or both.
Steps to Reproduce
- Set
CODER_OAUTH2_GITHUB_ALLOWED_ORGSto anything - Start a fresh Coder deployment
- Try to log in
Environment
Coder v2.21.3+bd1ef88 (not in the video but I did check and it's the same.
Additional Context
This sometimes leaves the Coder deployment in a broken state when restarted (the deployment thinks it has a user but you can't use it).
The user that reported this got a different issue, but I believe the cause to be the same.
