From 618765370d51f903a2b85d46a55c5fad73bb4ab5 Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 23 Oct 2024 16:41:46 +0100 Subject: [PATCH 1/5] fix(helm): default serviceAccount.disableCreate=false, add tests --- helm/coder/tests/chart_test.go | 4 + helm/coder/tests/testdata/sa_disabled.golden | 177 +++++++++++++++++++ helm/coder/tests/testdata/sa_disabled.yaml | 5 + helm/coder/values.yaml | 2 +- 4 files changed, 187 insertions(+), 1 deletion(-) create mode 100644 helm/coder/tests/testdata/sa_disabled.golden create mode 100644 helm/coder/tests/testdata/sa_disabled.yaml diff --git a/helm/coder/tests/chart_test.go b/helm/coder/tests/chart_test.go index d9bf4fee0c4ae..c04e075da6e43 100644 --- a/helm/coder/tests/chart_test.go +++ b/helm/coder/tests/chart_test.go @@ -88,6 +88,10 @@ var testCases = []testCase{ name: "sa_extra_rules", expectedError: "", }, + { + name: "sa_disabled", + expectedError: "", + }, } type testCase struct { diff --git a/helm/coder/tests/testdata/sa_disabled.golden b/helm/coder/tests/testdata/sa_disabled.golden new file mode 100644 index 0000000000000..3911c8a134164 --- /dev/null +++ b/helm/coder/tests/testdata/sa_disabled.golden @@ -0,0 +1,177 @@ +--- +# Source: coder/templates/rbac.yaml +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: coder-workspace-perms +rules: + - apiGroups: [""] + resources: ["pods"] + verbs: + - create + - delete + - deletecollection + - get + - list + - patch + - update + - watch + - apiGroups: [""] + resources: ["persistentvolumeclaims"] + verbs: + - create + - delete + - deletecollection + - get + - list + - patch + - update + - watch + - apiGroups: + - apps + resources: + - deployments + verbs: + - create + - delete + - deletecollection + - get + - list + - patch + - update + - watch +--- +# Source: coder/templates/rbac.yaml +apiVersion: rbac.authorization.k8s.io/v1 +kind: RoleBinding +metadata: + name: "coder" +subjects: + - kind: ServiceAccount + name: "coder" +roleRef: + apiGroup: rbac.authorization.k8s.io + kind: Role + name: coder-workspace-perms +--- +# Source: coder/templates/service.yaml +apiVersion: v1 +kind: Service +metadata: + name: coder + labels: + helm.sh/chart: coder-0.1.0 + app.kubernetes.io/name: coder + app.kubernetes.io/instance: release-name + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: "0.1.0" + app.kubernetes.io/managed-by: Helm + annotations: + {} +spec: + type: LoadBalancer + sessionAffinity: None + ports: + - name: "http" + port: 80 + targetPort: "http" + protocol: TCP + + externalTrafficPolicy: "Cluster" + selector: + app.kubernetes.io/name: coder + app.kubernetes.io/instance: release-name +--- +# Source: coder/templates/coder.yaml +--- +apiVersion: apps/v1 +kind: Deployment +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +spec: + replicas: 1 + selector: + matchLabels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/name: coder + template: + metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + spec: + affinity: + podAntiAffinity: + preferredDuringSchedulingIgnoredDuringExecution: + - podAffinityTerm: + labelSelector: + matchExpressions: + - key: app.kubernetes.io/instance + operator: In + values: + - coder + topologyKey: kubernetes.io/hostname + weight: 1 + containers: + - args: + - server + command: + - /opt/coder + env: + - name: CODER_HTTP_ADDRESS + value: 0.0.0.0:8080 + - name: CODER_PROMETHEUS_ADDRESS + value: 0.0.0.0:2112 + - name: CODER_ACCESS_URL + value: http://coder.default.svc.cluster.local + - name: KUBE_POD_IP + valueFrom: + fieldRef: + fieldPath: status.podIP + - name: CODER_DERP_SERVER_RELAY_URL + value: http://$(KUBE_POD_IP):8080 + image: ghcr.io/coder/coder:latest + imagePullPolicy: IfNotPresent + lifecycle: {} + livenessProbe: + httpGet: + path: /healthz + port: http + scheme: HTTP + name: coder + ports: + - containerPort: 8080 + name: http + protocol: TCP + readinessProbe: + httpGet: + path: /healthz + port: http + scheme: HTTP + resources: {} + securityContext: + allowPrivilegeEscalation: false + readOnlyRootFilesystem: null + runAsGroup: 1000 + runAsNonRoot: true + runAsUser: 1000 + seccompProfile: + type: RuntimeDefault + volumeMounts: [] + restartPolicy: Always + serviceAccountName: coder + terminationGracePeriodSeconds: 60 + volumes: [] diff --git a/helm/coder/tests/testdata/sa_disabled.yaml b/helm/coder/tests/testdata/sa_disabled.yaml new file mode 100644 index 0000000000000..cc74e52155a3d --- /dev/null +++ b/helm/coder/tests/testdata/sa_disabled.yaml @@ -0,0 +1,5 @@ +coder: + image: + tag: latest + serviceAccount: + disableCreate: true diff --git a/helm/coder/values.yaml b/helm/coder/values.yaml index 1e4ae4dddcd92..5ecb28e6b9b42 100644 --- a/helm/coder/values.yaml +++ b/helm/coder/values.yaml @@ -114,7 +114,7 @@ coder: # coder.serviceAccount.name -- The service account name name: coder # coder.serviceAccount.name -- Whether to create the service account or use existing service account - disableCreate: true + disableCreate: false # coder.securityContext -- Fields related to the container's security # context (as opposed to the pod). Some fields are also present in the pod From 61879d5a9866bbbdb5799cbcb18f5d3a12145ccc Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 23 Oct 2024 16:45:25 +0100 Subject: [PATCH 2/5] Revert "fix: make helm golden files to fix ci (#15196)" This reverts commit 57386ed677f3fbb47dc6231f45ad7f866caf46e6. --- .../tests/testdata/auto_access_url_1.golden | 15 ++++++++++++++- .../tests/testdata/auto_access_url_2.golden | 15 ++++++++++++++- .../tests/testdata/auto_access_url_3.golden | 15 ++++++++++++++- helm/coder/tests/testdata/command.golden | 15 ++++++++++++++- helm/coder/tests/testdata/command_args.golden | 15 ++++++++++++++- helm/coder/tests/testdata/default_values.golden | 15 ++++++++++++++- helm/coder/tests/testdata/env_from.golden | 15 ++++++++++++++- helm/coder/tests/testdata/extra_templates.golden | 15 ++++++++++++++- .../tests/testdata/labels_annotations.golden | 15 ++++++++++++++- helm/coder/tests/testdata/prometheus.golden | 15 ++++++++++++++- .../coder/tests/testdata/provisionerd_psk.golden | 15 ++++++++++++++- helm/coder/tests/testdata/sa.golden | 16 +++++++++++++++- helm/coder/tests/testdata/sa_extra_rules.golden | 15 ++++++++++++++- helm/coder/tests/testdata/tls.golden | 15 ++++++++++++++- helm/coder/tests/testdata/workspace_proxy.golden | 15 ++++++++++++++- 15 files changed, 211 insertions(+), 15 deletions(-) diff --git a/helm/coder/tests/testdata/auto_access_url_1.golden b/helm/coder/tests/testdata/auto_access_url_1.golden index bf11f21dcc148..a55a7413fb95b 100644 --- a/helm/coder/tests/testdata/auto_access_url_1.golden +++ b/helm/coder/tests/testdata/auto_access_url_1.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/auto_access_url_2.golden b/helm/coder/tests/testdata/auto_access_url_2.golden index 11f79709ce869..c7dd0b3c8780b 100644 --- a/helm/coder/tests/testdata/auto_access_url_2.golden +++ b/helm/coder/tests/testdata/auto_access_url_2.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/auto_access_url_3.golden b/helm/coder/tests/testdata/auto_access_url_3.golden index 0c1d88bd50c21..2a07c1e42f050 100644 --- a/helm/coder/tests/testdata/auto_access_url_3.golden +++ b/helm/coder/tests/testdata/auto_access_url_3.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/command.golden b/helm/coder/tests/testdata/command.golden index e072d91349597..9897e34382d6c 100644 --- a/helm/coder/tests/testdata/command.golden +++ b/helm/coder/tests/testdata/command.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/command_args.golden b/helm/coder/tests/testdata/command_args.golden index 0b97f491ec3e6..126127838b89c 100644 --- a/helm/coder/tests/testdata/command_args.golden +++ b/helm/coder/tests/testdata/command_args.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/default_values.golden b/helm/coder/tests/testdata/default_values.golden index 3911c8a134164..f5d6b2ad2c82f 100644 --- a/helm/coder/tests/testdata/default_values.golden +++ b/helm/coder/tests/testdata/default_values.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/env_from.golden b/helm/coder/tests/testdata/env_from.golden index c2d8ea07b4d34..caef038614e90 100644 --- a/helm/coder/tests/testdata/env_from.golden +++ b/helm/coder/tests/testdata/env_from.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/extra_templates.golden b/helm/coder/tests/testdata/extra_templates.golden index 53abcde705053..437b7ce13d15d 100644 --- a/helm/coder/tests/testdata/extra_templates.golden +++ b/helm/coder/tests/testdata/extra_templates.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/extra-templates.yaml apiVersion: v1 kind: ConfigMap @@ -92,7 +106,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/labels_annotations.golden b/helm/coder/tests/testdata/labels_annotations.golden index 6fbaaae72bb82..c6598737d2410 100644 --- a/helm/coder/tests/testdata/labels_annotations.golden +++ b/helm/coder/tests/testdata/labels_annotations.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/prometheus.golden b/helm/coder/tests/testdata/prometheus.golden index ebe10c9389dfc..a16fcc1a08493 100644 --- a/helm/coder/tests/testdata/prometheus.golden +++ b/helm/coder/tests/testdata/prometheus.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -84,7 +98,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/provisionerd_psk.golden b/helm/coder/tests/testdata/provisionerd_psk.golden index af1726ea8b563..93f9e817ebc80 100644 --- a/helm/coder/tests/testdata/provisionerd_psk.golden +++ b/helm/coder/tests/testdata/provisionerd_psk.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/sa.golden b/helm/coder/tests/testdata/sa.golden index f872c577119ca..386131531bef4 100644 --- a/helm/coder/tests/testdata/sa.golden +++ b/helm/coder/tests/testdata/sa.golden @@ -1,4 +1,19 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: + eks.amazonaws.com/role-arn: arn:aws:iam::123456789012:role/coder-service-account + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder-service-account +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +98,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/sa_extra_rules.golden b/helm/coder/tests/testdata/sa_extra_rules.golden index 25e4613603455..5766f45c6c829 100644 --- a/helm/coder/tests/testdata/sa_extra_rules.golden +++ b/helm/coder/tests/testdata/sa_extra_rules.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -97,7 +111,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/tls.golden b/helm/coder/tests/testdata/tls.golden index d53b243d3fd30..33b1a85b9d56b 100644 --- a/helm/coder/tests/testdata/tls.golden +++ b/helm/coder/tests/testdata/tls.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -88,7 +102,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: diff --git a/helm/coder/tests/testdata/workspace_proxy.golden b/helm/coder/tests/testdata/workspace_proxy.golden index f2494d01a96a4..4ac30acbad86b 100644 --- a/helm/coder/tests/testdata/workspace_proxy.golden +++ b/helm/coder/tests/testdata/workspace_proxy.golden @@ -1,4 +1,18 @@ --- +# Source: coder/templates/coder.yaml +apiVersion: v1 +kind: ServiceAccount +metadata: + annotations: {} + labels: + app.kubernetes.io/instance: release-name + app.kubernetes.io/managed-by: Helm + app.kubernetes.io/name: coder + app.kubernetes.io/part-of: coder + app.kubernetes.io/version: 0.1.0 + helm.sh/chart: coder-0.1.0 + name: coder +--- # Source: coder/templates/rbac.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: Role @@ -83,7 +97,6 @@ spec: app.kubernetes.io/instance: release-name --- # Source: coder/templates/coder.yaml ---- apiVersion: apps/v1 kind: Deployment metadata: From 740b7fd17d10e4886c71945548e485a4d49967ee Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 23 Oct 2024 16:50:54 +0100 Subject: [PATCH 3/5] ci: ensure changes to helm run go tests --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 77d747466f1f3..fa5164b91caa4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -90,6 +90,7 @@ jobs: - "coderd/**" - "enterprise/**" - "examples/*" + - "helm/**" - "provisioner/**" - "provisionerd/**" - "provisionersdk/**" From 19a429d48567c387c2d4304fde90e4672609165f Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 23 Oct 2024 16:51:38 +0100 Subject: [PATCH 4/5] make sure previous commit works --- helm/coder/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/coder/values.yaml b/helm/coder/values.yaml index 5ecb28e6b9b42..03ee5f634f406 100644 --- a/helm/coder/values.yaml +++ b/helm/coder/values.yaml @@ -17,7 +17,7 @@ coder: # # We will additionally set CODER_ACCESS_URL if unset to the cluster service # URL, unless coder.envUseClusterAccessURL is set to false. - env: [] + env: ["CIAN_TESTING_REMOVE_ME"] # - name: "CODER_ACCESS_URL" # value: "https://coder.example.com" From ca0031d498ce519e772463fc5e7dc8e22c31f541 Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 23 Oct 2024 17:09:44 +0100 Subject: [PATCH 5/5] Revert "make sure previous commit works" This reverts commit 19a429d48567c387c2d4304fde90e4672609165f. --- helm/coder/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/coder/values.yaml b/helm/coder/values.yaml index 03ee5f634f406..5ecb28e6b9b42 100644 --- a/helm/coder/values.yaml +++ b/helm/coder/values.yaml @@ -17,7 +17,7 @@ coder: # # We will additionally set CODER_ACCESS_URL if unset to the cluster service # URL, unless coder.envUseClusterAccessURL is set to false. - env: ["CIAN_TESTING_REMOVE_ME"] + env: [] # - name: "CODER_ACCESS_URL" # value: "https://coder.example.com" pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy