From f3bff34c934dba8fa7d5740cdc108d9cd18985fe Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Wed, 8 Jan 2025 17:45:23 +0000 Subject: [PATCH] chore(enterprise/coderd): conditionally disable parallelism for certain tests on windows --- enterprise/coderd/workspaces_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/enterprise/coderd/workspaces_test.go b/enterprise/coderd/workspaces_test.go index fb5d0eeea8651..17685df83b387 100644 --- a/enterprise/coderd/workspaces_test.go +++ b/enterprise/coderd/workspaces_test.go @@ -6,6 +6,7 @@ import ( "database/sql" "fmt" "net/http" + "runtime" "sync/atomic" "testing" "time" @@ -1398,8 +1399,12 @@ func TestTemplateDoesNotAllowUserAutostop(t *testing.T) { // real Terraform provisioner and validate that the workspace is created // successfully. The workspace itself does not specify any resources, and // this is fine. +// nolint:paralleltest // this test tends to time out on windows runners +// when run in parallel func TestWorkspaceTagsTerraform(t *testing.T) { - t.Parallel() + if runtime.GOOS != "windows" { + t.Parallel() + } mainTfTemplate := ` terraform { @@ -1528,7 +1533,9 @@ func TestWorkspaceTagsTerraform(t *testing.T) { } { tc := tc t.Run(tc.name, func(t *testing.T) { - t.Parallel() + if runtime.GOOS != "windows" { + t.Parallel() + } ctx := testutil.Context(t, testutil.WaitSuperLong) client, owner := coderdenttest.New(t, &coderdenttest.Options{ pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy