From 43d42b2ae91bc1b75ee1ab77ab1da7390f2e3ee4 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Tue, 25 Feb 2025 14:20:13 +0100 Subject: [PATCH] fix: no templates match criteria --- site/src/components/Filter/storyHelpers.ts | 4 +++- site/src/pages/TemplatesPage/EmptyTemplates.tsx | 6 ++++++ .../TemplatesPage/TemplatesPageView.stories.tsx | 13 +++++++++++++ site/src/pages/TemplatesPage/TemplatesPageView.tsx | 1 + 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/site/src/components/Filter/storyHelpers.ts b/site/src/components/Filter/storyHelpers.ts index 92285b41e48ee..9ee1bfaef96ac 100644 --- a/site/src/components/Filter/storyHelpers.ts +++ b/site/src/components/Filter/storyHelpers.ts @@ -17,17 +17,19 @@ export const getDefaultFilterProps = ({ query = "", values, menus, + used = false, }: { query?: string; values: Record; menus: Record; + used?: boolean; }) => ({ filter: { query, update: () => action("update"), debounceUpdate: action("debounce") as UseFilterResult["debounceUpdate"], - used: false, + used: used, values, }, menus, diff --git a/site/src/pages/TemplatesPage/EmptyTemplates.tsx b/site/src/pages/TemplatesPage/EmptyTemplates.tsx index 3bda4a5c97e67..5cefe910b1569 100644 --- a/site/src/pages/TemplatesPage/EmptyTemplates.tsx +++ b/site/src/pages/TemplatesPage/EmptyTemplates.tsx @@ -38,12 +38,18 @@ const findFeaturedExamples = (examples: TemplateExample[]) => { interface EmptyTemplatesProps { canCreateTemplates: boolean; examples: TemplateExample[]; + isUsingFilter: boolean; } export const EmptyTemplates: FC = ({ canCreateTemplates, examples, + isUsingFilter, }) => { + if (isUsingFilter) { + return ; + } + const featuredExamples = findFeaturedExamples(examples); if (canCreateTemplates) { diff --git a/site/src/pages/TemplatesPage/TemplatesPageView.stories.tsx b/site/src/pages/TemplatesPage/TemplatesPageView.stories.tsx index f07ad24df133c..7572f39b4b365 100644 --- a/site/src/pages/TemplatesPage/TemplatesPageView.stories.tsx +++ b/site/src/pages/TemplatesPage/TemplatesPageView.stories.tsx @@ -84,6 +84,19 @@ export const MultipleOrganizations: Story = { }, }; +export const WithFilteredAllTemplates: Story = { + args: { + ...WithTemplates.args, + templates: [], + ...getDefaultFilterProps({ + query: "deprecated:false searchnotfound", + menus: {}, + values: {}, + used: true, + }), + }, +}; + export const EmptyCanCreate: Story = { args: { canCreateTemplates: true, diff --git a/site/src/pages/TemplatesPage/TemplatesPageView.tsx b/site/src/pages/TemplatesPage/TemplatesPageView.tsx index 6d85aa293b16d..aa4276f8df472 100644 --- a/site/src/pages/TemplatesPage/TemplatesPageView.tsx +++ b/site/src/pages/TemplatesPage/TemplatesPageView.tsx @@ -246,6 +246,7 @@ export const TemplatesPageView: FC = ({ ) : ( templates?.map((template) => ( pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy