diff --git a/coderd/database/lock.go b/coderd/database/lock.go index 0bc8b2a75d001..4daea1f9699a5 100644 --- a/coderd/database/lock.go +++ b/coderd/database/lock.go @@ -18,5 +18,7 @@ const ( func GenLockID(name string) int64 { hash := fnv.New64() _, _ = hash.Write([]byte(name)) - return int64(hash.Sum64()) + // For our locking purposes, it's acceptable to have potential overflow + // The important part is consistency of the lock ID for a given name + return int64(hash.Sum64()) // #nosec G115 -- potential overflow is acceptable for lock IDs } diff --git a/coderd/database/modelmethods.go b/coderd/database/modelmethods.go index a9dbc3e530994..4a50b2f9c488b 100644 --- a/coderd/database/modelmethods.go +++ b/coderd/database/modelmethods.go @@ -160,7 +160,8 @@ func (t Template) DeepCopy() Template { func (t Template) AutostartAllowedDays() uint8 { // Just flip the binary 0s to 1s and vice versa. // There is an extra day with the 8th bit that needs to be zeroed. - return ^uint8(t.AutostartBlockDaysOfWeek) & 0b01111111 + // The conversion is safe because AutostartBlockDaysOfWeek is enforced to use only the lower 7 bits + return ^uint8(t.AutostartBlockDaysOfWeek) & 0b01111111 // #nosec G115 -- int16 to uint8 is safe as we only use 7 bits } func (TemplateVersion) RBACObject(template Template) rbac.Object { diff --git a/coderd/schedule/template.go b/coderd/schedule/template.go index a68cebd1fac93..5aea493c14347 100644 --- a/coderd/schedule/template.go +++ b/coderd/schedule/template.go @@ -77,7 +77,7 @@ func (r TemplateAutostopRequirement) DaysMap() map[time.Weekday]bool { func daysMap(daysOfWeek uint8) map[time.Weekday]bool { days := make(map[time.Weekday]bool) for i, day := range DaysOfWeek { - days[day] = daysOfWeek&(1<> 63 diff --git a/tailnet/convert.go b/tailnet/convert.go index 74b067632f231..38d95a3122132 100644 --- a/tailnet/convert.go +++ b/tailnet/convert.go @@ -31,7 +31,7 @@ func NodeToProto(n *Node) (*proto.Node, error) { } derpForcedWebsocket := make(map[int32]string) for i, s := range n.DERPForcedWebsocket { - derpForcedWebsocket[int32(i)] = s + derpForcedWebsocket[int32(i)] = s // #nosec G115 -- int to int32 is safe for indices } addresses := make([]string, len(n.Addresses)) for i, prefix := range n.Addresses { pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy