From 99a6e6840a9e9dc44980307dccb80945b5b2df19 Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden@coder.com>
Date: Tue, 27 May 2025 14:48:42 +0000
Subject: [PATCH 1/2] chore: hide classic workspace checkbox when experiment is
 not enabled

---
 .../TemplateSettingsForm.tsx                  | 62 ++++++++++---------
 1 file changed, 34 insertions(+), 28 deletions(-)

diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
index 71adb89e14f48..36366dc3f0045 100644
--- a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
+++ b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
@@ -24,6 +24,7 @@ import {
 	StackLabelHelperText,
 } from "components/StackLabel/StackLabel";
 import { type FormikTouched, useFormik } from "formik";
+import { useDashboard } from "modules/dashboard/useDashboard";
 import type { FC } from "react";
 import {
 	displayNameValidator,
@@ -97,6 +98,8 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 		initialTouched,
 	});
 	const getFieldHelpers = getFormHelpers(form, error);
+	const { experiments } = useDashboard();
+	const dynamicParametersEnabled = experiments.includes("dynamic-parameters");
 
 	return (
 		<HorizontalForm
@@ -224,34 +227,37 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 							</StackLabel>
 						}
 					/>
-					<FormControlLabel
-						control={
-							<Checkbox
-								size="small"
-								id="use_classic_parameter_flow"
-								name="use_classic_parameter_flow"
-								checked={form.values.use_classic_parameter_flow}
-								onChange={form.handleChange}
-								disabled={false}
-							/>
-						}
-						label={
-							<StackLabel>
-								Use classic workspace creation form
-								<StackLabelHelperText>
-									<span>
-										Show the original workspace creation form without dynamic
-										parameters or live updates. Recommended if your provisioners
-										aren't updated or the new form causes issues.{" "}
-										<strong>
-											Users can always manually switch experiences in the
-											workspace creation form.
-										</strong>
-									</span>
-								</StackLabelHelperText>
-							</StackLabel>
-						}
-					/>
+					{dynamicParametersEnabled && (
+						<FormControlLabel
+							control={
+								<Checkbox
+									size="small"
+									id="use_classic_parameter_flow"
+									name="use_classic_parameter_flow"
+									checked={form.values.use_classic_parameter_flow}
+									onChange={form.handleChange}
+									disabled={false}
+								/>
+							}
+							label={
+								<StackLabel>
+									Use classic workspace creation form
+									<StackLabelHelperText>
+										<span>
+											Show the original workspace creation form and workspace
+											parameters settings form without dynamic parameters or
+											live updates. Recommended if your provisioners aren't
+											updated or the new form causes issues.{" "}
+											<strong>
+												Users can always manually switch experiences in the
+												workspace creation form.
+											</strong>
+										</span>
+									</StackLabelHelperText>
+								</StackLabel>
+							}
+						/>
+					)}
 				</FormFields>
 			</FormSection>
 

From 00b50bb3e8e1638c1a57eb9e8ca0284c9f8e28eb Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden@coder.com>
Date: Tue, 27 May 2025 15:23:05 +0000
Subject: [PATCH 2/2] fix: retrieve experiments at page level

---
 .../TemplateGeneralSettingsPage/TemplateSettingsForm.tsx   | 7 +++----
 .../TemplateGeneralSettingsPage/TemplateSettingsPage.tsx   | 3 +++
 .../TemplateSettingsPageView.tsx                           | 3 +++
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
index 36366dc3f0045..8ba0e7b948b8c 100644
--- a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
+++ b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx
@@ -24,7 +24,6 @@ import {
 	StackLabelHelperText,
 } from "components/StackLabel/StackLabel";
 import { type FormikTouched, useFormik } from "formik";
-import { useDashboard } from "modules/dashboard/useDashboard";
 import type { FC } from "react";
 import {
 	displayNameValidator,
@@ -64,6 +63,7 @@ export interface TemplateSettingsForm {
 	accessControlEnabled: boolean;
 	advancedSchedulingEnabled: boolean;
 	portSharingControlsEnabled: boolean;
+	isDynamicParametersEnabled: boolean;
 }
 
 export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
@@ -76,6 +76,7 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 	accessControlEnabled,
 	advancedSchedulingEnabled,
 	portSharingControlsEnabled,
+	isDynamicParametersEnabled,
 }) => {
 	const form = useFormik<UpdateTemplateMeta>({
 		initialValues: {
@@ -98,8 +99,6 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 		initialTouched,
 	});
 	const getFieldHelpers = getFormHelpers(form, error);
-	const { experiments } = useDashboard();
-	const dynamicParametersEnabled = experiments.includes("dynamic-parameters");
 
 	return (
 		<HorizontalForm
@@ -227,7 +226,7 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({
 							</StackLabel>
 						}
 					/>
-					{dynamicParametersEnabled && (
+					{isDynamicParametersEnabled && (
 						<FormControlLabel
 							control={
 								<Checkbox
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
index be5af252aec31..e27f0b75c81e4 100644
--- a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
+++ b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
@@ -14,6 +14,8 @@ import { useTemplateSettings } from "../TemplateSettingsLayout";
 import { TemplateSettingsPageView } from "./TemplateSettingsPageView";
 
 const TemplateSettingsPage: FC = () => {
+	const { experiments } = useDashboard();
+	const isDynamicParametersEnabled = experiments.includes("dynamic-parameters");
 	const { template: templateName } = useParams() as { template: string };
 	const navigate = useNavigate();
 	const getLink = useLinks();
@@ -79,6 +81,7 @@ const TemplateSettingsPage: FC = () => {
 				accessControlEnabled={accessControlEnabled}
 				advancedSchedulingEnabled={advancedSchedulingEnabled}
 				sharedPortControlsEnabled={sharedPortControlsEnabled}
+				isDynamicParametersEnabled={isDynamicParametersEnabled}
 			/>
 		</>
 	);
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPageView.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPageView.tsx
index e267d25ce572e..059999d27bb74 100644
--- a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPageView.tsx
+++ b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPageView.tsx
@@ -15,6 +15,7 @@ interface TemplateSettingsPageViewProps {
 	accessControlEnabled: boolean;
 	advancedSchedulingEnabled: boolean;
 	sharedPortControlsEnabled: boolean;
+	isDynamicParametersEnabled: boolean;
 }
 
 export const TemplateSettingsPageView: FC<TemplateSettingsPageViewProps> = ({
@@ -27,6 +28,7 @@ export const TemplateSettingsPageView: FC<TemplateSettingsPageViewProps> = ({
 	accessControlEnabled,
 	advancedSchedulingEnabled,
 	sharedPortControlsEnabled,
+	isDynamicParametersEnabled,
 }) => {
 	return (
 		<>
@@ -44,6 +46,7 @@ export const TemplateSettingsPageView: FC<TemplateSettingsPageViewProps> = ({
 				accessControlEnabled={accessControlEnabled}
 				advancedSchedulingEnabled={advancedSchedulingEnabled}
 				portSharingControlsEnabled={sharedPortControlsEnabled}
+				isDynamicParametersEnabled={isDynamicParametersEnabled}
 			/>
 		</>
 	);

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/18061.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/18061.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/18061.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/18061.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>