diff --git a/enterprise/coderd/groups.go b/enterprise/coderd/groups.go
index cfe5d081271e3..89671e00bd65c 100644
--- a/enterprise/coderd/groups.go
+++ b/enterprise/coderd/groups.go
@@ -171,6 +171,12 @@ func (api *API) patchGroup(rw http.ResponseWriter, r *http.Request) {
})
return
}
+ // Skip membership checks for the prebuilds user. There is a valid use case
+ // for adding the prebuilds user to a single group: in order to set a quota
+ // allowance specifically for prebuilds.
+ if id == database.PrebuildsSystemUserID.String() {
+ continue
+ }
_, err := database.ExpectOne(api.Database.OrganizationMembers(ctx, database.OrganizationMembersParams{
OrganizationID: group.OrganizationID,
UserID: uuid.MustParse(id),
diff --git a/enterprise/coderd/groups_test.go b/enterprise/coderd/groups_test.go
index f87a9193f5fa4..568825adcd0ea 100644
--- a/enterprise/coderd/groups_test.go
+++ b/enterprise/coderd/groups_test.go
@@ -463,6 +463,32 @@ func TestPatchGroup(t *testing.T) {
require.Equal(t, http.StatusBadRequest, cerr.StatusCode())
})
+ // For quotas to work with prebuilds, it's currently required to add the
+ // prebuilds user into a group with a quota allowance.
+ // See: docs/admin/templates/extending-templates/prebuilt-workspaces.md
+ t.Run("PrebuildsUser", func(t *testing.T) {
+ t.Parallel()
+
+ client, user := coderdenttest.New(t, &coderdenttest.Options{LicenseOptions: &coderdenttest.LicenseOptions{
+ Features: license.Features{
+ codersdk.FeatureTemplateRBAC: 1,
+ },
+ }})
+ userAdminClient, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID, rbac.RoleUserAdmin())
+ ctx := testutil.Context(t, testutil.WaitLong)
+ group, err := userAdminClient.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{
+ Name: "prebuilds",
+ QuotaAllowance: 123,
+ })
+ require.NoError(t, err)
+
+ group, err = userAdminClient.PatchGroup(ctx, group.ID, codersdk.PatchGroupRequest{
+ Name: "prebuilds",
+ AddUsers: []string{database.PrebuildsSystemUserID.String()},
+ })
+ require.NoError(t, err)
+ })
+
t.Run("Everyone", func(t *testing.T) {
t.Parallel()
t.Run("NoUpdateName", func(t *testing.T) {
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy