= ({ builds, className }) => {
const status = getDisplayWorkspaceBuildStatus(theme, build)
const navigateToBuildPage = () => {
- navigate(`/builds/${build.id}`)
+ navigate(`/@${username}/${workspaceName}/builds/${build.build_number}`)
}
return (
diff --git a/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx b/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx
index cebff84da793d..45d13caa88496 100644
--- a/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx
+++ b/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx
@@ -1,6 +1,11 @@
import { screen } from "@testing-library/react"
import * as API from "../../api/api"
-import { MockWorkspaceBuild, MockWorkspaceBuildLogs, renderWithAuth } from "../../testHelpers/renderHelpers"
+import {
+ MockWorkspace,
+ MockWorkspaceBuild,
+ MockWorkspaceBuildLogs,
+ renderWithAuth,
+} from "../../testHelpers/renderHelpers"
import { WorkspaceBuildPage } from "./WorkspaceBuildPage"
describe("WorkspaceBuildPage", () => {
@@ -16,7 +21,10 @@ describe("WorkspaceBuildPage", () => {
closed: Promise.resolve(undefined),
cancel: jest.fn(),
})
- renderWithAuth(, { route: `/builds/${MockWorkspaceBuild.id}`, path: "/builds/:buildId" })
+ renderWithAuth(, {
+ route: `/@${MockWorkspace.owner_name}/${MockWorkspace.name}/builds/${MockWorkspace.latest_build.build_number}`,
+ path: "/@:username/:workspace/builds/:buildNumber",
+ })
await screen.findByText(MockWorkspaceBuild.workspace_name)
await screen.findByText(MockWorkspaceBuildLogs[0].stage)
diff --git a/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.tsx b/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.tsx
index 46550ac62225a..9d570db458dfe 100644
--- a/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.tsx
+++ b/site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.tsx
@@ -6,19 +6,9 @@ import { pageTitle } from "../../util/page"
import { workspaceBuildMachine } from "../../xServices/workspaceBuild/workspaceBuildXService"
import { WorkspaceBuildPageView } from "./WorkspaceBuildPageView"
-const useBuildId = () => {
- const { buildId } = useParams()
-
- if (!buildId) {
- throw new Error("buildId param is required.")
- }
-
- return buildId
-}
-
export const WorkspaceBuildPage: FC = () => {
- const buildId = useBuildId()
- const [buildState] = useMachine(workspaceBuildMachine, { context: { buildId } })
+ const { username, workspace: workspaceName, buildNumber } = useParams()
+ const [buildState] = useMachine(workspaceBuildMachine, { context: { username, workspaceName, buildNumber } })
const { logs, build } = buildState.context
const isWaitingForLogs = !buildState.matches("logs.loaded")
diff --git a/site/src/testHelpers/handlers.ts b/site/src/testHelpers/handlers.ts
index b77dd09c11aca..bfb8e9be0f4ff 100644
--- a/site/src/testHelpers/handlers.ts
+++ b/site/src/testHelpers/handlers.ts
@@ -115,7 +115,7 @@ export const handlers = [
rest.get("/api/v2/workspaces/:workspaceId/builds", async (req, res, ctx) => {
return res(ctx.status(200), ctx.json(M.MockBuilds))
}),
- rest.get("/api/v2/workspacebuilds/:workspaceBuildId", (req, res, ctx) => {
+ rest.get("/api/v2/users/:username/workspace/:workspaceName/builds/:buildNumber", (req, res, ctx) => {
return res(ctx.status(200), ctx.json(M.MockWorkspaceBuild))
}),
rest.get("/api/v2/workspacebuilds/:workspaceBuildId/resources", (req, res, ctx) => {
diff --git a/site/src/xServices/workspaceBuild/workspaceBuildXService.ts b/site/src/xServices/workspaceBuild/workspaceBuildXService.ts
index 88008892fe251..81883b3eaaa08 100644
--- a/site/src/xServices/workspaceBuild/workspaceBuildXService.ts
+++ b/site/src/xServices/workspaceBuild/workspaceBuildXService.ts
@@ -4,6 +4,9 @@ import { ProvisionerJobLog, WorkspaceBuild } from "../../api/typesGenerated"
type LogsContext = {
// Build
+ username: string
+ workspaceName: string
+ buildNumber: string
buildId: string
build?: WorkspaceBuild
getBuildError?: Error | unknown
@@ -36,28 +39,23 @@ export const workspaceBuildMachine = createMachine(
},
},
tsTypes: {} as import("./workspaceBuildXService.typegen").Typegen0,
- type: "parallel",
+ initial: "gettingBuild",
states: {
- build: {
- initial: "gettingBuild",
- states: {
- gettingBuild: {
- entry: "clearGetBuildError",
- invoke: {
- src: "getWorkspaceBuild",
- onDone: {
- target: "idle",
- actions: "assignBuild",
- },
- onError: {
- target: "idle",
- actions: "assignGetBuildError",
- },
- },
+ gettingBuild: {
+ entry: "clearGetBuildError",
+ invoke: {
+ src: "getWorkspaceBuild",
+ onDone: {
+ target: "logs",
+ actions: ["assignBuild", "assignBuildId"],
+ },
+ onError: {
+ target: "idle",
+ actions: "assignGetBuildError",
},
- idle: {},
},
},
+ idle: {},
logs: {
initial: "gettingExistentLogs",
states: {
@@ -95,6 +93,10 @@ export const workspaceBuildMachine = createMachine(
},
{
actions: {
+ // Build ID
+ assignBuildId: assign({
+ buildId: (_, event) => event.data.id,
+ }),
// Build
assignBuild: assign({
build: (_, event) => event.data,
@@ -117,7 +119,7 @@ export const workspaceBuildMachine = createMachine(
}),
},
services: {
- getWorkspaceBuild: (ctx) => API.getWorkspaceBuild(ctx.buildId),
+ getWorkspaceBuild: (ctx) => API.getWorkspaceBuildByNumber(ctx.username, ctx.workspaceName, ctx.buildNumber),
getLogs: async (ctx) => API.getWorkspaceBuildLogs(ctx.buildId),
streamWorkspaceBuildLogs: (ctx) => async (callback) => {
const reader = await API.streamWorkspaceBuildLogs(ctx.buildId)
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy