From 4ad9003d90e3de9b93aa0cfe15c34d49b294269e Mon Sep 17 00:00:00 2001
From: Kyle Carberry <kyle@carberry.com>
Date: Fri, 31 Mar 2023 21:18:48 +0000
Subject: [PATCH 1/5] fix: reduce spacing when agent metadata doesn't exist

---
 site/src/components/Resources/AgentMetadata.tsx | 13 ++++++++++++-
 site/src/components/Resources/AgentRow.tsx      |  8 ++------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
index df70543a30351..ac71423385f91 100644
--- a/site/src/components/Resources/AgentMetadata.tsx
+++ b/site/src/components/Resources/AgentMetadata.tsx
@@ -251,7 +251,16 @@ export const AgentMetadata: FC<{
   }, [agent.id, watchAgentMetadata])
 
   if (metadata === undefined) {
-    return <CircularProgress size={16} />
+    return (
+      <div
+        style={{
+          marginTop: 16,
+          marginBottom: 16,
+        }}
+      >
+        <CircularProgress size={16} />
+      </div>
+    )
   }
 
   return <AgentMetadataView metadata={metadata} />
@@ -264,6 +273,8 @@ const useStyles = makeStyles((theme) => ({
     border: `2px dashed ${theme.palette.divider}`,
     borderRadius: theme.shape.borderRadius,
     width: "100%",
+    marginTop: theme.spacing(2),
+    marginBottom: theme.spacing(2),
   },
   metadataHeader: {
     padding: "8px",
diff --git a/site/src/components/Resources/AgentRow.tsx b/site/src/components/Resources/AgentRow.tsx
index c00ca2a1793a0..7ebb7cab1e26d 100644
--- a/site/src/components/Resources/AgentRow.tsx
+++ b/site/src/components/Resources/AgentRow.tsx
@@ -180,11 +180,7 @@ export const AgentRow: FC<AgentRowProps> = ({
         <div className={styles.agentStatusWrapper}>
           <AgentStatus agent={agent} />
         </div>
-        <Stack
-          direction="column"
-          alignItems="flex-start"
-          key={agent.id}
-          spacing={2}
+        <div
           style={{
             flex: 1,
           }}
@@ -364,7 +360,7 @@ export const AgentRow: FC<AgentRowProps> = ({
               </Popover>
             </Stack>
           )}
-        </Stack>
+        </div>
       </Stack>
       {showStartupLogs && (
         <AutoSizer disableHeight>

From 396c069217f416ae4e48e0182b983191b7a162da Mon Sep 17 00:00:00 2001
From: Ammar Bandukwala <ammar@ammar.io>
Date: Fri, 31 Mar 2023 21:25:12 +0000
Subject: [PATCH 2/5] Remove grid

---
 site/src/components/Resources/AgentMetadata.tsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
index ac71423385f91..91684f87cce97 100644
--- a/site/src/components/Resources/AgentMetadata.tsx
+++ b/site/src/components/Resources/AgentMetadata.tsx
@@ -278,8 +278,7 @@ const useStyles = makeStyles((theme) => ({
   },
   metadataHeader: {
     padding: "8px",
-    display: "grid",
-    gridTemplateColumns: "repeat(4, minmax(0, 1fr))",
+    display: "flex",
     gap: theme.spacing(5),
     rowGap: theme.spacing(3),
   },

From 568641f120e81da18fc1e4777d44bd4b8ad22b0b Mon Sep 17 00:00:00 2001
From: Ammar Bandukwala <ammar@ammar.io>
Date: Fri, 31 Mar 2023 21:42:55 +0000
Subject: [PATCH 3/5] Add stories!

---
 .../components/Resources/AgentMetadata.tsx    |  9 +-
 .../components/Resources/AgentRow.stories.tsx | 87 +++++++++----------
 site/src/components/Resources/AgentRow.tsx    | 14 ++-
 3 files changed, 60 insertions(+), 50 deletions(-)

diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
index 91684f87cce97..feccd7e9d08bc 100644
--- a/site/src/components/Resources/AgentMetadata.tsx
+++ b/site/src/components/Resources/AgentMetadata.tsx
@@ -228,7 +228,8 @@ export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {
 
 export const AgentMetadata: FC<{
   agent: WorkspaceAgent
-}> = ({ agent }) => {
+  storybookMetadata?: WorkspaceAgentMetadata[]
+}> = ({ agent, storybookMetadata }) => {
   const [metadata, setMetadata] = useState<
     WorkspaceAgentMetadata[] | undefined
   >(undefined)
@@ -236,6 +237,10 @@ export const AgentMetadata: FC<{
   const watchAgentMetadata = useContext(WatchAgentMetadataContext)
 
   useEffect(() => {
+    if (storybookMetadata !== undefined) {
+      setMetadata(storybookMetadata)
+      return
+    }
     const source = watchAgentMetadata(agent.id)
 
     source.onerror = (e) => {
@@ -248,7 +253,7 @@ export const AgentMetadata: FC<{
     return () => {
       source.close()
     }
-  }, [agent.id, watchAgentMetadata])
+  }, [agent.id, watchAgentMetadata, storybookMetadata])
 
   if (metadata === undefined) {
     return (
diff --git a/site/src/components/Resources/AgentRow.stories.tsx b/site/src/components/Resources/AgentRow.stories.tsx
index 823c662ab70e0..316e23ff87557 100644
--- a/site/src/components/Resources/AgentRow.stories.tsx
+++ b/site/src/components/Resources/AgentRow.stories.tsx
@@ -24,37 +24,48 @@ export default {
 
 const Template: Story<AgentRowProps> = (args) => <AgentRow {...args} />
 
+const defaultAgentMetadata = [
+  {
+    result: {
+      collected_at: "2021-05-05T00:00:00Z",
+      error: "",
+      value: "defvalue",
+      age: 5,
+    },
+    description: {
+      display_name: "DisPlay",
+      key: "defkey",
+      interval: 10,
+      timeout: 10,
+      script: "some command",
+    },
+  },
+]
+
 export const Example = Template.bind({})
 Example.args = {
   agent: MockWorkspaceAgent,
   workspace: MockWorkspace,
   applicationsHost: "",
   showApps: true,
+  storybookAgentMetadata: defaultAgentMetadata,
 }
 
 export const HideSSHButton = Template.bind({})
 HideSSHButton.args = {
-  agent: MockWorkspaceAgent,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
+  ...Example.args,
   hideSSHButton: true,
 }
 
 export const HideVSCodeDesktopButton = Template.bind({})
 HideVSCodeDesktopButton.args = {
-  agent: MockWorkspaceAgent,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
+  ...Example.args,
   hideVSCodeDesktopButton: true,
 }
 
 export const NotShowingApps = Template.bind({})
 NotShowingApps.args = {
-  agent: MockWorkspaceAgent,
-  workspace: MockWorkspace,
-  applicationsHost: "",
+  ...Example.args,
   showApps: false,
 }
 
@@ -81,26 +92,21 @@ BunchOfApps.args = {
 
 export const Connecting = Template.bind({})
 Connecting.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentConnecting,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
+  storybookAgentMetadata: [],
 }
 
 export const Timeout = Template.bind({})
 Timeout.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentTimeout,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const Starting = Template.bind({})
 Starting.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentStarting,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 
   storybookStartupLogs: [
     "Cloning Git repository...",
@@ -117,13 +123,11 @@ Starting.args = {
 
 export const Started = Template.bind({})
 Started.args = {
+  ...Example.args,
   agent: {
     ...MockWorkspaceAgentReady,
     startup_logs_length: 1,
   },
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 
   storybookStartupLogs: [
     "Cloning Git repository...",
@@ -138,67 +142,58 @@ Started.args = {
   })),
 }
 
+export const StartedNoMetadata = Template.bind({})
+StartedNoMetadata.args = {
+  ...Started.args,
+  storybookAgentMetadata: [],
+}
+
 export const StartTimeout = Template.bind({})
 StartTimeout.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentStartTimeout,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const StartError = Template.bind({})
 StartError.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentStartError,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const ShuttingDown = Template.bind({})
 ShuttingDown.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentShuttingDown,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const ShutdownTimeout = Template.bind({})
 ShutdownTimeout.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentShutdownTimeout,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const ShutdownError = Template.bind({})
 ShutdownError.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentShutdownError,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const Off = Template.bind({})
 Off.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentOff,
-  workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
 }
 
 export const ShowingPortForward = Template.bind({})
 ShowingPortForward.args = {
-  agent: MockWorkspaceAgent,
-  workspace: MockWorkspace,
+  ...Example.args,
   applicationsHost: "https://coder.com",
-  showApps: true,
 }
 
 export const Outdated = Template.bind({})
 Outdated.args = {
+  ...Example.args,
   agent: MockWorkspaceAgentOutdated,
   workspace: MockWorkspace,
-  applicationsHost: "",
-  showApps: true,
   serverVersion: "v99.999.9999+c1cdf14",
 }
diff --git a/site/src/components/Resources/AgentRow.tsx b/site/src/components/Resources/AgentRow.tsx
index 7ebb7cab1e26d..d8d0eec49fb85 100644
--- a/site/src/components/Resources/AgentRow.tsx
+++ b/site/src/components/Resources/AgentRow.tsx
@@ -29,7 +29,12 @@ import {
   LineWithID,
   workspaceAgentLogsMachine,
 } from "xServices/workspaceAgentLogs/workspaceAgentLogsXService"
-import { Workspace, WorkspaceAgent } from "../../api/typesGenerated"
+import {
+  Workspace,
+  WorkspaceAgent,
+  WorkspaceAgentMetadata,
+  WorkspaceAgentMetadataDescription,
+} from "../../api/typesGenerated"
 import { AppLink } from "../AppLink/AppLink"
 import { SSHButton } from "../SSHButton/SSHButton"
 import { Stack } from "../Stack/Stack"
@@ -51,6 +56,7 @@ export interface AgentRowProps {
   onUpdateAgent: () => void
 
   storybookStartupLogs?: LineWithID[]
+  storybookAgentMetadata?: WorkspaceAgentMetadata[]
 }
 
 export const AgentRow: FC<AgentRowProps> = ({
@@ -63,6 +69,7 @@ export const AgentRow: FC<AgentRowProps> = ({
   serverVersion,
   onUpdateAgent,
   storybookStartupLogs,
+  storybookAgentMetadata,
   sshPrefix,
 }) => {
   const styles = useStyles()
@@ -287,7 +294,10 @@ export const AgentRow: FC<AgentRowProps> = ({
               )}
             </Stack>
           </Stack>
-          <AgentMetadata agent={agent} />
+          <AgentMetadata
+            storybookMetadata={storybookAgentMetadata}
+            agent={agent}
+          />
           {hasStartupFeatures && (
             <Stack
               direction="row"

From 6d432b7662caa1644d63e11ad25a3cfc419a6b5c Mon Sep 17 00:00:00 2001
From: Ammar Bandukwala <ammar@ammar.io>
Date: Fri, 31 Mar 2023 21:49:35 +0000
Subject: [PATCH 4/5] Test for massive values

---
 .../components/Resources/AgentMetadata.stories.tsx    | 11 +++++++++++
 site/src/components/Resources/AgentMetadata.tsx       |  1 +
 2 files changed, 12 insertions(+)

diff --git a/site/src/components/Resources/AgentMetadata.stories.tsx b/site/src/components/Resources/AgentMetadata.stories.tsx
index 8b6fc80a9f683..b5159a5830db2 100644
--- a/site/src/components/Resources/AgentMetadata.stories.tsx
+++ b/site/src/components/Resources/AgentMetadata.stories.tsx
@@ -103,5 +103,16 @@ Example.args = {
         key: "nloads",
       },
     },
+    {
+      result: {
+        ...resultDefaults,
+        value: "r".repeat(1000),
+      },
+      description: {
+        ...descriptionDefaults,
+        display_name: "Really, really big",
+        key: "big",
+      },
+    },
   ],
 }
diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
index feccd7e9d08bc..0fecc908a65ae 100644
--- a/site/src/components/Resources/AgentMetadata.tsx
+++ b/site/src/components/Resources/AgentMetadata.tsx
@@ -305,6 +305,7 @@ const useStyles = makeStyles((theme) => ({
     textOverflow: "ellipsis",
     overflow: "hidden",
     whiteSpace: "nowrap",
+    maxWidth: "16em",
   },
 
   metadataValueSuccess: {

From 3680f9e63f97db16a465d61fba76c13c7ed4c268 Mon Sep 17 00:00:00 2001
From: Ammar Bandukwala <ammar@ammar.io>
Date: Fri, 31 Mar 2023 22:00:43 +0000
Subject: [PATCH 5/5] fixup! Test for massive values

---
 site/src/components/Resources/AgentRow.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/site/src/components/Resources/AgentRow.tsx b/site/src/components/Resources/AgentRow.tsx
index d8d0eec49fb85..882cb5c2313a0 100644
--- a/site/src/components/Resources/AgentRow.tsx
+++ b/site/src/components/Resources/AgentRow.tsx
@@ -33,7 +33,6 @@ import {
   Workspace,
   WorkspaceAgent,
   WorkspaceAgentMetadata,
-  WorkspaceAgentMetadataDescription,
 } from "../../api/typesGenerated"
 import { AppLink } from "../AppLink/AppLink"
 import { SSHButton } from "../SSHButton/SSHButton"

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/6937.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/6937.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/6937.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/coder/coder/pull/6937.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>