chore: sign user out on launch if token expired

ethanndickson · ethanndickson · commit 15066a390673 · 2025-03-11T18:05:53.000+11:00
diff --git a/Coder Desktop/Coder Desktop/Coder_DesktopApp.swift b/Coder Desktop/Coder Desktop/Coder_DesktopApp.swift
@@ -56,6 +56,10 @@ class AppDelegate: NSObject, NSApplicationDelegate {
                 state.reconfigure()
             }
         }
+        // Sign out if token is expired
+        Task { @MainActor in
+            await state.handleTokenExpiry()
+        }
     }
 
     // This function MUST eventually call `NSApp.reply(toApplicationShouldTerminate: true)`
diff --git a/Coder Desktop/Coder Desktop/State.swift b/Coder Desktop/Coder Desktop/State.swift
@@ -3,7 +3,9 @@ import Foundation
 import KeychainAccess
 import NetworkExtension
 import SwiftUI
+import CoderSDK
 
+@MainActor
 class AppState: ObservableObject {
     let appId = Bundle.main.bundleIdentifier!
 
@@ -94,6 +96,9 @@ class AppState: ObservableObject {
         )
         if hasSession {
             _sessionToken = Published(initialValue: keychainGet(for: Keys.sessionToken))
+            if sessionToken == nil || sessionToken!.isEmpty == true {
+                hasSession = false
+            }
         }
     }
 
@@ -104,6 +109,23 @@ class AppState: ObservableObject {
         reconfigure()
     }
 
+    public func handleTokenExpiry() async {
+        if hasSession {
+            let client = Client(url: self.baseAccessURL!, token: self.sessionToken!)
+            do {
+                _ = try await client.user("me")
+            } catch let ClientError.api(apiErr) {
+                // Expired token
+                if apiErr.statusCode == 401 {
+                    clearSession()
+                }
+            } catch {
+                // Some other failure, we'll show an error if they try and do something
+                return
+            }
+        }
+    }
+
     public func clearSession() {
         hasSession = false
         sessionToken = nil
diff --git a/Coder Desktop/CoderSDK/Client.swift b/Coder Desktop/CoderSDK/Client.swift
@@ -104,10 +104,10 @@ public struct Client {
 }
 
 public struct APIError: Decodable, Sendable {
-    let response: Response
-    let statusCode: Int
-    let method: String
-    let url: URL
+    public let response: Response
+    public let statusCode: Int
+    public let method: String
+    public let url: URL
 
     var description: String {
         var components = ["\(method) \(url.absoluteString)\nUnexpected status code \(statusCode):\n\(response.message)"]

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@ class AppDelegate: NSObject, NSApplicationDelegate {`
`56`	`56`	`state.reconfigure()`
`57`	`57`	`}`
`58`	`58`	`}`
	`59`	`+ // Sign out if token is expired`
	`60`	`+ Task { @MainActor in`
	`61`	`+ await state.handleTokenExpiry()`
	`62`	`+ }`
`59`	`63`	`}`
`60`	`64`
`61`	`65`	// This function MUST eventually call `NSApp.reply(toApplicationShouldTerminate: true)`