fix: correct remote file picker dropdown chevron alignment (#192)

ethanndickson · web-flow · commit 15f1890fea07 · 2025-07-09T20:00:46.000+10:00
There appears to be a bug when a View created using `NSView` is inside a `DisclosureGroup` label - regardless of the size of the `NSView`, it breaks the alignment of the chevron that's included on the DisclosureGroup label by default: ![](https://github.com/user-attachments/assets/d6a14a29-1b79-4a82-ac9f-62cf88142140) In #184 we added an `NSView` to the spinner, causing this issue. This is almost certainly a SwiftUI bug, and so we'll work around it by placing the spinner and error symbol to the right of the label by just setting a trailing padding on the text. The end result (with spinners on): ![](https://github.com/user-attachments/assets/50a7a7d3-bc68-4e02-b023-505b05759bf9)
diff --git a/Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift b/Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift
@@ -123,12 +123,18 @@ struct FilePickerEntry: View {
         } label: {
             Label {
                 Text(entry.name)
-                ZStack {
-                    CircularProgressView(value: nil, strokeWidth: 2, diameter: 10)
-                        .opacity(entry.isLoading && entry.error == nil ? 1 : 0)
-                    Image(systemName: "exclamationmark.triangle.fill")
-                        .opacity(entry.error != nil ? 1 : 0)
-                }
+                    // The NSView within the CircularProgressView breaks
+                    // the chevron alignment within the DisclosureGroup view.
+                    // So, we overlay the progressview with a manual offset
+                    .padding(.trailing, 20)
+                    .overlay(alignment: .trailing) {
+                        ZStack {
+                            CircularProgressView(value: nil, strokeWidth: 2, diameter: 10)
+                                .opacity(entry.isLoading && entry.error == nil ? 1 : 0)
+                            Image(systemName: "exclamationmark.triangle.fill")
+                                .opacity(entry.error != nil ? 1 : 0)
+                        }
+                    }
             } icon: {
                 Image(systemName: "folder")
             }.help(entry.error != nil ? entry.error!.description : entry.absolute_path)
