remove max size

ethanndickson · ethanndickson · commit 19507799d470 · 2025-03-25T12:44:34.000+11:00
diff --git a/Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift b/Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
@@ -24,7 +24,7 @@ struct FileSyncConfig<VPN: VPNService, FS: FileSyncDaemon>: View {
                     .width(min: 100, ideal: 120)
                 TableColumn("Status") { $0.status.column.help($0.statusAndErrors) }
                     .width(min: 80, ideal: 100)
-                TableColumn("Size") { Text($0.maxSize.humanSizeBytes).help($0.sizeDescription) }
+                TableColumn("Size") { Text($0.localSize.humanSizeBytes).help($0.sizeDescription) }
                     .width(min: 60, ideal: 80)
             }
             .contextMenu(forSelectionType: FileSyncSession.ID.self, menu: { _ in },
diff --git a/Coder-Desktop/VPNLib/FileSync/FileSyncSession.swift b/Coder-Desktop/VPNLib/FileSync/FileSyncSession.swift
@@ -9,7 +9,6 @@ public struct FileSyncSession: Identifiable {
     public let betaPath: String
     public let status: FileSyncStatus
 
-    public let maxSize: FileSyncSessionEndpointSize
     public let localSize: FileSyncSessionEndpointSize
     public let remoteSize: FileSyncSessionEndpointSize
 
@@ -25,14 +24,14 @@ public struct FileSyncSession: Identifiable {
         } else {
             "Unknown"
         }
-        if state.session.beta.protocol == Url_Protocol.ssh, !state.session.beta.host.isEmpty {
+        agentHost = if state.session.beta.protocol == Url_Protocol.ssh, !state.session.beta.host.isEmpty {
             // TOOD: We need to either:
             // - make this compatible with custom suffixes
             // - always strip the tld
             // - always keep the tld
-            agentHost = state.session.beta.host
+            state.session.beta.host
         } else {
-            agentHost = "Unknown"
+            "Unknown"
         }
         betaPath = if !state.session.beta.path.isEmpty {
             state.session.beta.path
@@ -64,7 +63,6 @@ public struct FileSyncSession: Identifiable {
             dirCount: state.betaState.directories,
             symLinkCount: state.betaState.symbolicLinks
         )
-        maxSize = localSize.maxOf(other: remoteSize)
 
         errors = accumulateErrors(from: state)
     }
@@ -77,9 +75,6 @@ public struct FileSyncSession: Identifiable {
 
     public var sizeDescription: String {
         var out = ""
-        if localSize != remoteSize {
-            out += "Maximum:\n\(maxSize.description(linePrefix: " "))\n\n"
-        }
         out += "Local:\n\(localSize.description(linePrefix: " "))\n\n"
         out += "Remote:\n\(remoteSize.description(linePrefix: " "))"
         return out
@@ -99,15 +94,6 @@ public struct FileSyncSessionEndpointSize: Equatable {
         self.symLinkCount = symLinkCount
     }
 
-    func maxOf(other: FileSyncSessionEndpointSize) -> FileSyncSessionEndpointSize {
-        FileSyncSessionEndpointSize(
-            sizeBytes: max(sizeBytes, other.sizeBytes),
-            fileCount: max(fileCount, other.fileCount),
-            dirCount: max(dirCount, other.dirCount),
-            symLinkCount: max(symLinkCount, other.symLinkCount)
-        )
-    }
-
     public var humanSizeBytes: String {
         humanReadableBytes(sizeBytes)
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ struct FileSyncConfig<VPN: VPNService, FS: FileSyncDaemon>: View {`
`24`	`24`	`.width(min: 100, ideal: 120)`
`25`	`25`	`TableColumn("Status") { $0.status.column.help($0.statusAndErrors) }`
`26`	`26`	`.width(min: 80, ideal: 100)`
`27`		`- TableColumn("Size") { Text($0.maxSize.humanSizeBytes).help($0.sizeDescription) }`
	`27`	`+ TableColumn("Size") { Text($0.localSize.humanSizeBytes).help($0.sizeDescription) }`
`28`	`28`	`.width(min: 60, ideal: 80)`
`29`	`29`	`}`
`30`	`30`	`.contextMenu(forSelectionType: FileSyncSession.ID.self, menu: { _ in },`