chore: enforce minimum coder server version of v2.20.0

ethanndickson · ethanndickson · commit 4bafba543b53 · 2025-03-07T12:04:53.000+11:00
diff --git a/Coder Desktop/VPNLib/Download.swift b/Coder Desktop/VPNLib/Download.swift
@@ -10,6 +10,7 @@ public enum ValidationError: Error {
     case invalidTeamIdentifier(identifier: String?)
     case missingInfoPList
     case invalidVersion(version: String?)
+    case belowMinimumCoderVersion
 
     public var description: String {
         switch self {
@@ -29,13 +30,18 @@ public enum ValidationError: Error {
             "Invalid team identifier: \(identifier ?? "unknown")."
         case .missingInfoPList:
             "Info.plist is not embedded within the dylib."
+        case .belowMinimumCoderVersion:
+            "The Coder deployment must be version \(SignatureValidator.minimumCoderVersion) or higher to use Coder Desktop."
         }
     }
 
     public var localizedDescription: String { description }
 }
 
 public class SignatureValidator {
+    // Whilst older dylibs exist, this app assumes v2.20 or later.
+    static let minimumCoderVersion = "2.20.0"
+
     private static let expectedName = "CoderVPN"
     private static let expectedIdentifier = "com.coder.Coder-Desktop.VPN.dylib"
     private static let expectedTeamIdentifier = "4399GN35BJ"
@@ -95,11 +101,20 @@ public class SignatureValidator {
             throw .invalidIdentifier(identifier: infoPlist[infoNameKey] as? String)
         }
 
+        // Downloaded dylib must match the version of the server
         guard let dylibVersion = infoPlist[infoShortVersionKey] as? String,
-              expectedVersion.compare(dylibVersion, options: .numeric) != .orderedDescending
+              expectedVersion == dylibVersion
         else {
             throw .invalidVersion(version: infoPlist[infoShortVersionKey] as? String)
         }
+
+        // Downloaded dylib must be at least the minimum Coder server version
+        guard let dylibVersion = infoPlist[infoShortVersionKey] as? String,
+              // x.compare(y) is .orderedDescending if x > y
+              minimumCoderVersion.compare(dylibVersion, options: .numeric) != .orderedDescending
+        else {
+            throw .belowMinimumCoderVersion
+        }
     }
 }
 
