also check at login

ethanndickson · ethanndickson · commit 73b126de536e · 2025-03-07T18:33:40.000+11:00
diff --git a/Coder Desktop/Coder Desktop/Views/LoginForm.swift b/Coder Desktop/Coder Desktop/Views/LoginForm.swift
@@ -1,5 +1,6 @@
 import CoderSDK
 import SwiftUI
+import VPNLib
 
 struct LoginForm: View {
     @EnvironmentObject var state: AppState
@@ -78,6 +79,22 @@ struct LoginForm: View {
             loginError = .failedAuth(error)
             return
         }
+        let buildInfo: BuildInfoResponse
+        do {
+            buildInfo = try await client.buildInfo()
+        } catch {
+            loginError = .failedAuth(error)
+            return
+        }
+        guard let semver = buildInfo.semver else {
+            loginError = .missingServerVersion
+            return
+        }
+        // x.compare(y) is .orderedDescending if x > y
+        guard SignatureValidator.minimumCoderVersion.compare(semver, options: .numeric) != .orderedDescending else {
+            loginError = .outdatedCoderVersion
+            return
+        }
         state.login(baseAccessURL: url, sessionToken: sessionToken)
         dismiss()
     }
@@ -190,6 +207,8 @@ enum LoginError: Error {
     case httpsRequired
     case noHost
     case invalidURL
+    case outdatedCoderVersion
+    case missingServerVersion
     case failedAuth(ClientError)
 
     var description: String {
@@ -200,8 +219,15 @@ enum LoginError: Error {
             "URL must have a host"
         case .invalidURL:
             "Invalid URL"
+        case .outdatedCoderVersion:
+            """
+            The Coder deployment must be version \(SignatureValidator.minimumCoderVersion)
+            or higher to use Coder Desktop.
+            """
         case let .failedAuth(err):
             "Could not authenticate with Coder deployment:\n\(err.localizedDescription)"
+        case .missingServerVersion:
+            "Coder deployment did not provide a server version"
         }
     }
 
diff --git a/Coder Desktop/VPNLib/Download.swift b/Coder Desktop/VPNLib/Download.swift
@@ -43,7 +43,7 @@ public enum ValidationError: Error {
 
 public class SignatureValidator {
     // Whilst older dylibs exist, this app assumes v2.20 or later.
-    static let minimumCoderVersion = "2.20.0"
+    public static let minimumCoderVersion = "2.20.0"
 
     private static let expectedName = "CoderVPN"
     private static let expectedIdentifier = "com.coder.Coder-Desktop.VPN.dylib"
