feat: make workspace app icons smaller, neater (#152)

ethanndickson · web-flow · commit 79b0f7cb037e · 2025-05-07T16:29:23.000+10:00
https://github.com/user-attachments/assets/77436fc1-dcab-4246-8307-f0e69081ca06
diff --git a/Coder-Desktop/Coder-Desktop/Theme.swift b/Coder-Desktop/Coder-Desktop/Theme.swift
@@ -8,8 +8,8 @@ enum Theme {
 
         static let rectCornerRadius: CGFloat = 4
 
-        static let appIconWidth: CGFloat = 30
-        static let appIconHeight: CGFloat = 30
+        static let appIconWidth: CGFloat = 17
+        static let appIconHeight: CGFloat = 17
         static let appIconSize: CGSize = .init(width: appIconWidth, height: appIconHeight)
     }
 
diff --git a/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenuItem.swift b/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenuItem.swift
@@ -180,20 +180,18 @@ struct MenuItemView: View {
 }
 
 struct MenuItemCollapsibleView: View {
-    private let defaultVisibleApps = 5
+    private let defaultVisibleApps = 6
     let apps: [WorkspaceApp]
 
     var body: some View {
-        HStack(spacing: 17) {
+        HStack(spacing: 16) {
             ForEach(apps.prefix(defaultVisibleApps), id: \.id) { app in
                 WorkspaceAppIcon(app: app)
                     .frame(width: Theme.Size.appIconWidth, height: Theme.Size.appIconHeight)
             }
-            if apps.count < defaultVisibleApps {
-                Spacer()
-            }
+            Spacer()
         }
-        .padding(.leading, apps.count < defaultVisibleApps ? 14 : 0)
+        .padding(.leading, 32)
         .padding(.bottom, 5)
         .padding(.top, 10)
     }
diff --git a/Coder-Desktop/Coder-Desktop/Views/VPN/WorkspaceAppIcon.swift b/Coder-Desktop/Coder-Desktop/Views/VPN/WorkspaceAppIcon.swift
@@ -19,9 +19,9 @@ struct WorkspaceAppIcon: View {
                 ) { $0 }
                     placeholder: {
                         if app.icon != nil {
-                            ProgressView()
+                            ProgressView().controlSize(.small)
                         } else {
-                            Text(app.displayName).frame(
+                            Image(systemName: "questionmark").frame(
                                 width: Theme.Size.appIconWidth,
                                 height: Theme.Size.appIconHeight
                             )
@@ -30,14 +30,11 @@ struct WorkspaceAppIcon: View {
                         width: Theme.Size.appIconWidth,
                         height: Theme.Size.appIconHeight
                     )
-            }.padding(4)
+            }.padding(6)
         }
+        .background(isHovering ? Color.accentColor.opacity(0.8) : .clear)
         .clipShape(RoundedRectangle(cornerRadius: 8))
-        .overlay(
-            RoundedRectangle(cornerRadius: Theme.Size.rectCornerRadius * 2)
-                .stroke(.secondary, lineWidth: 1)
-                .opacity(isHovering && !isPressed ? 0.6 : 0.3)
-        ).onHover { hovering in isHovering = hovering }
+        .onHover { hovering in isHovering = hovering }
         .simultaneousGesture(
             DragGesture(minimumDistance: 0)
                 .onChanged { _ in

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ enum Theme {`
`8`	`8`
`9`	`9`	`static let rectCornerRadius: CGFloat = 4`
`10`	`10`
`11`		`- static let appIconWidth: CGFloat = 30`
`12`		`- static let appIconHeight: CGFloat = 30`
	`11`	`+ static let appIconWidth: CGFloat = 17`
	`12`	`+ static let appIconHeight: CGFloat = 17`
`13`	`13`	`static let appIconSize: CGSize = .init(width: appIconWidth, height: appIconHeight)`
`14`	`14`	`}`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -180,20 +180,18 @@ struct MenuItemView: View {`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`struct MenuItemCollapsibleView: View {`
`183`		`- private let defaultVisibleApps = 5`
	`183`	`+ private let defaultVisibleApps = 6`
`184`	`184`	`let apps: [WorkspaceApp]`
`185`	`185`
`186`	`186`	`var body: some View {`
`187`		`- HStack(spacing: 17) {`
	`187`	`+ HStack(spacing: 16) {`
`188`	`188`	`ForEach(apps.prefix(defaultVisibleApps), id: \.id) { app in`
`189`	`189`	`WorkspaceAppIcon(app: app)`
`190`	`190`	`.frame(width: Theme.Size.appIconWidth, height: Theme.Size.appIconHeight)`
`191`	`191`	`}`
`192`		`- if apps.count < defaultVisibleApps {`
`193`		`- Spacer()`
`194`		`- }`
	`192`	`+ Spacer()`
`195`	`193`	`}`
`196`		`- .padding(.leading, apps.count < defaultVisibleApps ? 14 : 0)`
	`194`	`+ .padding(.leading, 32)`
`197`	`195`	`.padding(.bottom, 5)`
`198`	`196`	`.padding(.top, 10)`
`199`	`197`	`}`