review

ethanndickson · ethanndickson · commit ddaf081a4de9 · 2025-08-07T16:29:34.000+10:00
diff --git a/Coder-Desktop/Coder-Desktop/UpdaterService.swift b/Coder-Desktop/Coder-Desktop/UpdaterService.swift
@@ -5,11 +5,7 @@ final class UpdaterService: NSObject, ObservableObject {
     // The auto-updater can be entirely disabled by setting the
     // `disableUpdater` UserDefaults key to `true`. This is designed for use in
     // MDM configurations, where the value can be set to `true` permanently.
-    @Published var disabled: Bool = UserDefaults.standard.bool(forKey: Keys.disableUpdater) {
-        didSet {
-            UserDefaults.standard.set(disabled, forKey: Keys.disableUpdater)
-        }
-    }
+    let disabled: Bool = UserDefaults.standard.bool(forKey: Keys.disableUpdater)
 
     @Published var canCheckForUpdates = true
 
diff --git a/Coder-Desktop/Coder-Desktop/VPN/VPNService.swift b/Coder-Desktop/Coder-Desktop/VPN/VPNService.swift
@@ -56,7 +56,7 @@ final class CoderVPNService: NSObject, VPNService {
     var logger = Logger(subsystem: Bundle.main.bundleIdentifier!, category: "vpn")
     lazy var xpc: HelperXPCClient = .init(vpn: self)
 
-    @Published var tunnelState: VPNServiceState = .disabled {
+    @Published private(set) var tunnelState: VPNServiceState = .disabled {
         didSet {
             if tunnelState == .connecting {
                 progress = .init(stage: .initial, downloadProgress: nil)
@@ -80,9 +80,9 @@ final class CoderVPNService: NSObject, VPNService {
         return tunnelState
     }
 
-    @Published var progress: VPNProgress = .init(stage: .initial, downloadProgress: nil)
+    @Published private(set) var progress: VPNProgress = .init(stage: .initial, downloadProgress: nil)
 
-    @Published var menuState: VPNMenuState = .init()
+    @Published private(set) var menuState: VPNMenuState = .init()
 
     // Whether the VPN should start as soon as possible
     var startWhenReady: Bool = false
diff --git a/Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift b/Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift
@@ -69,9 +69,9 @@ struct FilePicker: View {
 
 @MainActor
 class FilePickerModel: ObservableObject {
-    @Published var rootEntries: [FilePickerEntryModel] = []
-    @Published var rootIsLoading: Bool = false
-    @Published var error: SDKError?
+    @Published private(set) var rootEntries: [FilePickerEntryModel] = []
+    @Published private(set) var rootIsLoading: Bool = false
+    @Published private(set) var error: SDKError?
 
     // It's important that `AgentClient` is a reference type (class)
     // as we were having performance issues with a struct (unless it was a binding).
@@ -153,9 +153,9 @@ class FilePickerEntryModel: Identifiable, Hashable, ObservableObject {
 
     let client: AgentClient
 
-    @Published var entries: [FilePickerEntryModel]?
-    @Published var isLoading = false
-    @Published var error: SDKError?
+    @Published private(set) var entries: [FilePickerEntryModel]?
+    @Published private(set) var isLoading = false
+    @Published private(set) var error: SDKError?
     @Published private var innerIsExpanded = false
     var isExpanded: Bool {
         get { innerIsExpanded }
diff --git a/Coder-Desktop/Coder-Desktop/Views/Settings/GeneralTab.swift b/Coder-Desktop/Coder-Desktop/Views/Settings/GeneralTab.swift
@@ -34,6 +34,11 @@ struct GeneralTab: View {
                         Button("Check for updates") { updater.checkForUpdates() }.disabled(!updater.canCheckForUpdates)
                     }
                 }
+            } else {
+                Section {
+                    Text("The app updater has been disabled by a device management policy.")
+                        .foregroundColor(.secondary)
+                }
             }
         }.formStyle(.grouped)
     }

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,11 @@ struct GeneralTab: View {`
`34`	`34`	`Button("Check for updates") { updater.checkForUpdates() }.disabled(!updater.canCheckForUpdates)`
`35`	`35`	`}`
`36`	`36`	`}`
	`37`	`+ } else {`
	`38`	`+ Section {`
	`39`	`+ Text("The app updater has been disabled by a device management policy.")`
	`40`	`+ .foregroundColor(.secondary)`
	`41`	`+ }`
`37`	`42`	`}`
`38`	`43`	`}.formStyle(.grouped)`
`39`	`44`	`}`