feat: add start vpn on launch setting (#108)

ethanndickson · web-flow · commit de63a7af518a · 2025-03-18T14:35:26.000+11:00
Relates to #104. On-demand is a pretty big lift - in the meantime we'll add a 'start VPN on launch' config setting.
diff --git a/Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift b/Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift
@@ -58,6 +58,9 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             if await !vpn.loadNetworkExtensionConfig() {
                 state.reconfigure()
             }
+            if state.startVPNOnLaunch {
+                await vpn.start()
+            }
         }
         // TODO: Start the daemon only once a file sync is configured
         Task {
diff --git a/Coder-Desktop/Coder-Desktop/State.swift b/Coder-Desktop/Coder-Desktop/State.swift
@@ -54,6 +54,13 @@ class AppState: ObservableObject {
         }
     }
 
+    @Published var startVPNOnLaunch: Bool = UserDefaults.standard.bool(forKey: Keys.startVPNOnLaunch) {
+        didSet {
+            guard persistent else { return }
+            UserDefaults.standard.set(startVPNOnLaunch, forKey: Keys.startVPNOnLaunch)
+        }
+    }
+
     func tunnelProviderProtocol() -> NETunnelProviderProtocol? {
         if !hasSession { return nil }
         let proto = NETunnelProviderProtocol()
@@ -133,6 +140,7 @@ class AppState: ObservableObject {
         static let useLiteralHeaders = "UseLiteralHeaders"
         static let literalHeaders = "LiteralHeaders"
         static let stopVPNOnQuit = "StopVPNOnQuit"
+        static let startVPNOnLaunch = "StartVPNOnLaunch"
     }
 }
 
diff --git a/Coder-Desktop/Coder-Desktop/Views/Settings/GeneralTab.swift b/Coder-Desktop/Coder-Desktop/Views/Settings/GeneralTab.swift
@@ -6,11 +6,16 @@ struct GeneralTab: View {
     var body: some View {
         Form {
             Section {
-                LaunchAtLogin.Toggle("Launch at Login")
+                LaunchAtLogin.Toggle("Launch at login")
             }
             Section {
                 Toggle(isOn: $state.stopVPNOnQuit) {
-                    Text("Stop Coder Connect on Quit")
+                    Text("Stop Coder Connect on quit")
+                }
+            }
+            Section {
+                Toggle(isOn: $state.startVPNOnLaunch) {
+                    Text("Start Coder Connect on launch")
                 }
             }
         }.formStyle(.grouped)

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,9 @@ class AppDelegate: NSObject, NSApplicationDelegate {`
`58`	`58`	`if await !vpn.loadNetworkExtensionConfig() {`
`59`	`59`	`state.reconfigure()`
`60`	`60`	`}`
	`61`	`+ if state.startVPNOnLaunch {`
	`62`	`+ await vpn.start()`
	`63`	`+ }`
`61`	`64`	`}`
`62`	`65`	`// TODO: Start the daemon only once a file sync is configured`
`63`	`66`	`Task {`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,13 @@ class AppState: ObservableObject {`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`
	`57`	`+ @Published var startVPNOnLaunch: Bool = UserDefaults.standard.bool(forKey: Keys.startVPNOnLaunch) {`
	`58`	`+ didSet {`
	`59`	`+ guard persistent else { return }`
	`60`	`+ UserDefaults.standard.set(startVPNOnLaunch, forKey: Keys.startVPNOnLaunch)`
	`61`	`+ }`
	`62`	`+ }`
	`63`	`+`
`57`	`64`	`func tunnelProviderProtocol() -> NETunnelProviderProtocol? {`
`58`	`65`	`if !hasSession { return nil }`
`59`	`66`	`let proto = NETunnelProviderProtocol()`
`@@ -133,6 +140,7 @@ class AppState: ObservableObject {`
`133`	`140`	`static let useLiteralHeaders = "UseLiteralHeaders"`
`134`	`141`	`static let literalHeaders = "LiteralHeaders"`
`135`	`142`	`static let stopVPNOnQuit = "StopVPNOnQuit"`
	`143`	`+ static let startVPNOnLaunch = "StartVPNOnLaunch"`
`136`	`144`	`}`
`137`	`145`	`}`
`138`	`146`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,16 @@ struct GeneralTab: View {`
`6`	`6`	`var body: some View {`
`7`	`7`	`Form {`
`8`	`8`	`Section {`
`9`		`- LaunchAtLogin.Toggle("Launch at Login")`
	`9`	`+ LaunchAtLogin.Toggle("Launch at login")`
`10`	`10`	`}`
`11`	`11`	`Section {`
`12`	`12`	`Toggle(isOn: $state.stopVPNOnQuit) {`
`13`		`- Text("Stop Coder Connect on Quit")`
	`13`	`+ Text("Stop Coder Connect on quit")`
	`14`	`+ }`
	`15`	`+ }`
	`16`	`+ Section {`
	`17`	`+ Toggle(isOn: $state.startVPNOnLaunch) {`
	`18`	`+ Text("Start Coder Connect on launch")`
`14`	`19`	`}`
`15`	`20`	`}`
`16`	`21`	`}.formStyle(.grouped)`