Skip to content

Commit f5d0741

Browse files
chore: set minimum coder server version to v2.24.3 (#215)
This requirement is introduced by #210, as the `vpn-daemon` command on the macOS CLI isn't present on prior versions. (2.24.3 isn't out yet, but when it does come out, it'll be compatible. 2.25 is out, and it's compatible)
1 parent 4ba6ca3 commit f5d0741

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

Coder-Desktop/Coder-DesktopTests/LoginFormTests.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import Mocker
44
import SwiftUI
55
import Testing
66
import ViewInspector
7+
@testable import VPNLib
78

89
@MainActor
910
@Suite(.timeLimit(.minutes(1)))
@@ -134,7 +135,7 @@ struct LoginTests {
134135
username: "admin"
135136
)
136137
let buildInfo = BuildInfoResponse(
137-
version: "v2.24.2"
138+
version: "v\(Validator.minimumCoderVersion)"
138139
)
139140

140141
try Mock(

Coder-Desktop/VPNLib/Validate.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ public enum ValidationError: Error {
4040

4141
public class Validator {
4242
// This version of the app has a strict version requirement.
43-
// TODO(ethanndickson): Set to 2.25.0
44-
public static let minimumCoderVersion = "2.24.2"
43+
public static let minimumCoderVersion = "2.24.3"
4544

4645
private static let expectedIdentifier = "com.coder.cli"
4746
// The Coder team identifier

Coder-Desktop/project.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,8 @@ targets:
256256
- target: "Coder Desktop"
257257
- target: CoderSDK
258258
embed: false # Do not embed the framework.
259+
- target: VPNLib
260+
embed: false # Do not embed the framework.
259261
- package: ViewInspector
260262
- package: Mocker
261263

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy