fix: fix Downloader to always dispose of temp file stream

spikecurtis · spikecurtis · commit 08002efea277 · 2025-04-29T16:17:56.000+04:00
diff --git a/Vpn.Service/Downloader.cs b/Vpn.Service/Downloader.cs
@@ -453,27 +453,26 @@ private async Task Start(CancellationToken ct = default)
         if (res.Content.Headers.ContentLength >= 0)
             TotalBytes = (ulong)res.Content.Headers.ContentLength;
 
-        FileStream tempFile;
-        try
-        {
-            tempFile = File.Create(TempDestinationPath, BufferSize,
-                FileOptions.Asynchronous | FileOptions.SequentialScan);
-        }
-        catch (Exception e)
-        {
-            _logger.LogError(e, "Failed to create temporary file '{TempDestinationPath}'", TempDestinationPath);
-            throw;
-        }
-
-        await Download(res, tempFile, ct);
+        await Download(res, ct);
         return;
     }
 
-    private async Task Download(HttpResponseMessage res, FileStream tempFile, CancellationToken ct)
+    private async Task Download(HttpResponseMessage res, CancellationToken ct)
     {
         try
         {
             var sha1 = res.Headers.Contains("ETag") ? SHA1.Create() : null;
+            FileStream tempFile;
+            try
+            {
+                tempFile = File.Create(TempDestinationPath, BufferSize,
+                    FileOptions.Asynchronous | FileOptions.SequentialScan);
+            }
+            catch (Exception e)
+            {
+                _logger.LogError(e, "Failed to create temporary file '{TempDestinationPath}'", TempDestinationPath);
+                throw;
+            }
             await using (tempFile)
             {
                 var stream = await res.Content.ReadAsStreamAsync(ct);
