fix: change dummy workspace logic to include starting and stopping (#107)

spikecurtis · web-flow · commit 204f0e3e2d23 · 2025-05-22T20:29:49.000+04:00
fixes #104 Includes starting, stopping, pending and unknown (rare!) workspaces as "dummy" grayed workspaces. TBD what we want to do with failed or canceled workspaces.
diff --git a/App/ViewModels/TrayWindowViewModel.cs b/App/ViewModels/TrayWindowViewModel.cs
@@ -207,7 +207,7 @@ private void UpdateFromRpcModel(RpcModel rpcModel)
         // For every stopped workspace that doesn't have any agents, add a
         // dummy agent row.
         foreach (var workspace in rpcModel.Workspaces.Where(w =>
-                     w.Status == Workspace.Types.Status.Stopped && !workspacesWithAgents.Contains(w.Id)))
+                     ShouldShowDummy(w) && !workspacesWithAgents.Contains(w.Id)))
         {
             if (!Uuid.TryFrom(workspace.Id.Span, out var uuid))
                 continue;
@@ -372,4 +372,21 @@ public void Exit()
     {
         _ = ((App)Application.Current).ExitApplication();
     }
+
+    private static bool ShouldShowDummy(Workspace workspace)
+    {
+        switch (workspace.Status)
+        {
+            case Workspace.Types.Status.Unknown:
+            case Workspace.Types.Status.Pending:
+            case Workspace.Types.Status.Starting:
+            case Workspace.Types.Status.Stopping:
+            case Workspace.Types.Status.Stopped:
+                return true;
+            // TODO: should we include and show a different color than Gray for workspaces that are
+            // failed, canceled or deleting?
+            default:
+                return false;
+        }
+    }
 }
