added comments

ibetitsmike · ibetitsmike · commit 88a1d27b75af · 2025-06-02T18:37:03.000+02:00
diff --git a/App/Services/SettingsManager.cs b/App/Services/SettingsManager.cs
@@ -98,18 +98,23 @@ private void Save(string name, bool value)
         {
             try
             {
-                // Ensure cache is loaded before saving
+                // We lock the file for the entire operation to prevent concurrent writes   
                 using var fs = new FileStream(_settingsFilePath,
                     FileMode.OpenOrCreate,
                     FileAccess.ReadWrite,
                     FileShare.None);
-                
-                var currentCache = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(fs) ?? new();
+
+                // Ensure cache is loaded before saving 
+                var currentCache = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(fs) ?? [];
                 _cache = currentCache;
                 _cache[name] = JsonSerializer.SerializeToElement(value);
-                fs.Position = 0; // Reset stream position to the beginning before writing to override the file
-                var options = new JsonSerializerOptions { WriteIndented = true};
-                JsonSerializer.Serialize(fs, _cache, options);
+                fs.Position = 0; // Reset stream position to the beginning before writing
+
+                JsonSerializer.Serialize(fs, _cache, new JsonSerializerOptions { WriteIndented = true });
+
+                // This ensures the file is truncated to the new length
+                // if the new content is shorter than the old content
+                fs.SetLength(fs.Position);
             }
             catch
             {
