chore: add debug logging to mutagen stop daemon

spikecurtis · spikecurtis · commit a17c91518f44 · 2025-04-30T15:18:28.000+04:00
diff --git a/App/Services/MutagenController.cs b/App/Services/MutagenController.cs
@@ -578,6 +578,7 @@ private void StartDaemonProcess()
     /// </summary>
     private async Task StopDaemon(CancellationToken ct)
     {
+        _logger.LogDebug("stopping mutagen daemon");
         var process = _daemonProcess;
         var client = _mutagenClient;
         var writer = _logWriter;
@@ -590,28 +591,34 @@ private async Task StopDaemon(CancellationToken ct)
             if (client == null)
             {
                 if (process == null) return;
+                _logger.LogDebug("no client; killing daemon process");
                 process.Kill(true);
             }
             else
             {
                 try
                 {
+                    _logger.LogDebug("sending DaemonTerminateRequest");
                     await client.Daemon.TerminateAsync(new DaemonTerminateRequest(), cancellationToken: ct);
                 }
-                catch
+                catch (Exception e)
                 {
+                    _logger.LogError(e, "failed to gracefully terminate agent");
                     if (process == null) return;
+                    _logger.LogDebug("killing daemon process after failed graceful termination");
                     process.Kill(true);
                 }
             }
 
             if (process == null) return;
             var cts = CancellationTokenSource.CreateLinkedTokenSource(ct);
             cts.CancelAfter(TimeSpan.FromSeconds(5));
+            _logger.LogDebug("waiting for process to exit");
             await process.WaitForExitAsync(cts.Token);
         }
         finally
         {
+            _logger.LogDebug("cleaning up daemon process objects");
             client?.Dispose();
             process?.Dispose();
             writer?.Dispose();

Original file line number	Diff line number	Diff line change
`@@ -578,6 +578,7 @@ private void StartDaemonProcess()`
`578`	`578`	`/// </summary>`
`579`	`579`	`private async Task StopDaemon(CancellationToken ct)`
`580`	`580`	`{`
	`581`	`+ _logger.LogDebug("stopping mutagen daemon");`
`581`	`582`	`var process = _daemonProcess;`
`582`	`583`	`var client = _mutagenClient;`
`583`	`584`	`var writer = _logWriter;`
`@@ -590,28 +591,34 @@ private async Task StopDaemon(CancellationToken ct)`
`590`	`591`	`if (client == null)`
`591`	`592`	`{`
`592`	`593`	`if (process == null) return;`
	`594`	`+ _logger.LogDebug("no client; killing daemon process");`
`593`	`595`	`process.Kill(true);`
`594`	`596`	`}`
`595`	`597`	`else`
`596`	`598`	`{`
`597`	`599`	`try`
`598`	`600`	`{`
	`601`	`+ _logger.LogDebug("sending DaemonTerminateRequest");`
`599`	`602`	`await client.Daemon.TerminateAsync(new DaemonTerminateRequest(), cancellationToken: ct);`
`600`	`603`	`}`
`601`		`- catch`
	`604`	`+ catch (Exception e)`
`602`	`605`	`{`
	`606`	`+ _logger.LogError(e, "failed to gracefully terminate agent");`
`603`	`607`	`if (process == null) return;`
	`608`	`+ _logger.LogDebug("killing daemon process after failed graceful termination");`
`604`	`609`	`process.Kill(true);`
`605`	`610`	`}`
`606`	`611`	`}`
`607`	`612`
`608`	`613`	`if (process == null) return;`
`609`	`614`	`var cts = CancellationTokenSource.CreateLinkedTokenSource(ct);`
`610`	`615`	`cts.CancelAfter(TimeSpan.FromSeconds(5));`
	`616`	`+ _logger.LogDebug("waiting for process to exit");`
`611`	`617`	`await process.WaitForExitAsync(cts.Token);`
`612`	`618`	`}`
`613`	`619`	`finally`
`614`	`620`	`{`
	`621`	`+ _logger.LogDebug("cleaning up daemon process objects");`
`615`	`622`	`client?.Dispose();`
`616`	`623`	`process?.Dispose();`
`617`	`624`	`writer?.Dispose();`