chore: revert network isolation UI (#152)

deansheather · web-flow · commit ac22fe4c44de · 2025-07-30T23:30:09.000+10:00
We're always going to be enabling the soft isolation mode now.
diff --git a/App/App.xaml.cs b/App/App.xaml.cs
@@ -92,7 +92,6 @@ public App()
 
         services.AddSingleton<IDispatcherQueueManager>(_ => this);
         services.AddSingleton<IDefaultNotificationHandler>(_ => this);
-        services.AddSingleton<ISettingsManager<CoderConnectSettings>, SettingsManager<CoderConnectSettings>>();
         services.AddSingleton<ICredentialBackend>(_ =>
             new WindowsCredentialBackend(WindowsCredentialBackend.CoderCredentialsTargetName));
         services.AddSingleton<ICredentialManager, CredentialManager>();
@@ -121,6 +120,7 @@ public App()
         // FileSyncListMainPage is created by FileSyncListWindow.
         services.AddTransient<FileSyncListWindow>();
 
+        services.AddSingleton<ISettingsManager<CoderConnectSettings>, SettingsManager<CoderConnectSettings>>();
         services.AddSingleton<IStartupManager, StartupManager>();
         // SettingsWindow views and view models
         services.AddTransient<SettingsViewModel>();
diff --git a/App/Models/Settings.cs b/App/Models/Settings.cs
@@ -34,11 +34,6 @@ public class CoderConnectSettings : ISettings<CoderConnectSettings>
     /// </summary>
     public bool ConnectOnLaunch { get; set; }
 
-    /// <summary>
-    /// When this is true Coder Connect will not attempt to protect against Tailscale loopback issues.
-    /// </summary>
-    public bool EnableCorporateVpnSupport { get; set; }
-
     /// <summary>
     /// CoderConnect current settings version. Increment this when the settings schema changes.
     /// In future iterations we will be able to handle migrations when the user has
@@ -51,21 +46,17 @@ public CoderConnectSettings()
         Version = VERSION;
 
         ConnectOnLaunch = false;
-
-        EnableCorporateVpnSupport = false;
     }
 
-    public CoderConnectSettings(int? version, bool connectOnLaunch, bool enableCorporateVpnSupport)
+    public CoderConnectSettings(int? version, bool connectOnLaunch)
     {
         Version = version ?? VERSION;
 
         ConnectOnLaunch = connectOnLaunch;
-
-        EnableCorporateVpnSupport = enableCorporateVpnSupport;
     }
 
     public CoderConnectSettings Clone()
     {
-        return new CoderConnectSettings(Version, ConnectOnLaunch, EnableCorporateVpnSupport);
+        return new CoderConnectSettings(Version, ConnectOnLaunch);
     }
 }
diff --git a/App/Services/RpcController.cs b/App/Services/RpcController.cs
@@ -69,18 +69,16 @@ public interface IRpcController : IAsyncDisposable
 public class RpcController : IRpcController
 {
     private readonly ICredentialManager _credentialManager;
-    private readonly ISettingsManager<CoderConnectSettings> _settingsManager;
 
     private readonly RaiiSemaphoreSlim _operationLock = new(1, 1);
     private Speaker<ClientMessage, ServiceMessage>? _speaker;
 
     private readonly RaiiSemaphoreSlim _stateLock = new(1, 1);
     private readonly RpcModel _state = new();
 
-    public RpcController(ICredentialManager credentialManager, ISettingsManager<CoderConnectSettings> settingsManager)
+    public RpcController(ICredentialManager credentialManager)
     {
         _credentialManager = credentialManager;
-        _settingsManager = settingsManager;
     }
 
     public event EventHandler<RpcModel>? StateChanged;
@@ -158,7 +156,6 @@ public async Task StartVpn(CancellationToken ct = default)
         using var _ = await AcquireOperationLockNowAsync();
         AssertRpcConnected();
 
-        var coderConnectSettings = await _settingsManager.Read(ct);
         var credentials = _credentialManager.GetCachedCredentials();
         if (credentials.State != CredentialState.Valid)
             throw new RpcOperationException(
@@ -178,7 +175,6 @@ public async Task StartVpn(CancellationToken ct = default)
                 {
                     CoderUrl = credentials.CoderUrl?.ToString(),
                     ApiToken = credentials.ApiToken,
-                    TunnelUseSoftNetIsolation = coderConnectSettings.EnableCorporateVpnSupport,
                 },
             }, ct);
         }
diff --git a/App/ViewModels/SettingsViewModel.cs b/App/ViewModels/SettingsViewModel.cs
@@ -13,9 +13,6 @@ public partial class SettingsViewModel : ObservableObject
     [ObservableProperty]
     public partial bool ConnectOnLaunch { get; set; }
 
-    [ObservableProperty]
-    public partial bool DisableTailscaleLoopProtection { get; set; }
-
     [ObservableProperty]
     public partial bool StartOnLoginDisabled { get; set; }
 
@@ -34,7 +31,6 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager<Cod
         _connectSettings = settingsManager.Read().GetAwaiter().GetResult();
         StartOnLogin = startupManager.IsEnabled();
         ConnectOnLaunch = _connectSettings.ConnectOnLaunch;
-        DisableTailscaleLoopProtection = _connectSettings.EnableCorporateVpnSupport;
 
         // Various policies can disable the "Start on login" option.
         // We disable the option in the UI if the policy is set.
@@ -47,21 +43,6 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager<Cod
         }
     }
 
-    partial void OnDisableTailscaleLoopProtectionChanged(bool oldValue, bool newValue)
-    {
-        if (oldValue == newValue)
-            return;
-        try
-        {
-            _connectSettings.EnableCorporateVpnSupport = DisableTailscaleLoopProtection;
-            _connectSettingsManager.Write(_connectSettings);
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError($"Error saving Coder Connect {nameof(DisableTailscaleLoopProtection)} settings: {ex.Message}");
-        }
-    }
-
     partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
     {
         if (oldValue == newValue)
@@ -73,7 +54,7 @@ partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
         }
         catch (Exception ex)
         {
-            _logger.LogError($"Error saving Coder Connect {nameof(ConnectOnLaunch)} settings: {ex.Message}");
+            _logger.LogError($"Error saving Coder Connect settings: {ex.Message}");
         }
     }
 
diff --git a/App/Views/Pages/SettingsMainPage.xaml b/App/Views/Pages/SettingsMainPage.xaml
@@ -44,12 +44,6 @@
                                        >
                     <ToggleSwitch IsOn="{x:Bind ViewModel.ConnectOnLaunch, Mode=TwoWay}" />
                 </controls:SettingsCard>
-                <controls:SettingsCard Description="This setting loosens some VPN loop protection checks in Coder Connect, allowing traffic to flow to a Coder deployment behind a corporate VPN. We only recommend enabling this option if Coder Connect doesn't work with your Coder deployment behind a corporate VPN."
-                       Header="Enable support for corporate VPNs"
-                       HeaderIcon="{ui:FontIcon Glyph=&#xE705;}"
-                       >
-                    <ToggleSwitch IsOn="{x:Bind ViewModel.DisableTailscaleLoopProtection, Mode=TwoWay}" />
-                </controls:SettingsCard>
             </StackPanel>
         </Grid>
     </ScrollViewer>
diff --git a/App/Views/SettingsWindow.xaml b/App/Views/SettingsWindow.xaml
@@ -9,8 +9,8 @@
     xmlns:winuiex="using:WinUIEx"
     mc:Ignorable="d"
     Title="Coder Settings"
-    Width="600" Height="500"
-    MinWidth="600" MinHeight="500">
+    Width="600" Height="350"
+    MinWidth="600" MinHeight="350">
 
     <Window.SystemBackdrop>
         <MicaBackdrop/>
diff --git a/Vpn.Proto/vpn.proto b/Vpn.Proto/vpn.proto
@@ -62,7 +62,7 @@ message ServiceMessage {
 		StartResponse start = 2;
 		StopResponse stop = 3;
 		Status status = 4;                // either in reply to a StatusRequest or broadcasted
-		StartProgress start_progress = 5; // broadcasted during startup (used exclusively by Windows)
+		StartProgress start_progress = 5; // broadcasted during startup
 	}
 }
 
@@ -214,7 +214,6 @@ message NetworkSettingsResponse {
 // StartResponse.
 message StartRequest {
 	int32 tunnel_file_descriptor = 1;
-	bool tunnel_use_soft_net_isolation = 8;
 	string coder_url = 2;
 	string api_token = 3;
 	// Additional HTTP headers added to all requests

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,6 @@ public class CoderConnectSettings : ISettings<CoderConnectSettings>`
`34`	`34`	`/// </summary>`
`35`	`35`	`public bool ConnectOnLaunch { get; set; }`
`36`	`36`
`37`		`- /// <summary>`
`38`		`- /// When this is true Coder Connect will not attempt to protect against Tailscale loopback issues.`
`39`		`- /// </summary>`
`40`		`- public bool EnableCorporateVpnSupport { get; set; }`
`41`		`-`
`42`	`37`	`/// <summary>`
`43`	`38`	`/// CoderConnect current settings version. Increment this when the settings schema changes.`
`44`	`39`	`/// In future iterations we will be able to handle migrations when the user has`
`@@ -51,21 +46,17 @@ public CoderConnectSettings()`
`51`	`46`	`Version = VERSION;`
`52`	`47`
`53`	`48`	`ConnectOnLaunch = false;`
`54`		`-`
`55`		`- EnableCorporateVpnSupport = false;`
`56`	`49`	`}`
`57`	`50`
`58`		`- public CoderConnectSettings(int? version, bool connectOnLaunch, bool enableCorporateVpnSupport)`
	`51`	`+ public CoderConnectSettings(int? version, bool connectOnLaunch)`
`59`	`52`	`{`
`60`	`53`	`Version = version ?? VERSION;`
`61`	`54`
`62`	`55`	`ConnectOnLaunch = connectOnLaunch;`
`63`		`-`
`64`		`- EnableCorporateVpnSupport = enableCorporateVpnSupport;`
`65`	`56`	`}`
`66`	`57`
`67`	`58`	`public CoderConnectSettings Clone()`
`68`	`59`	`{`
`69`		`- return new CoderConnectSettings(Version, ConnectOnLaunch, EnableCorporateVpnSupport);`
	`60`	`+ return new CoderConnectSettings(Version, ConnectOnLaunch);`
`70`	`61`	`}`
`71`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,18 +69,16 @@ public interface IRpcController : IAsyncDisposable`
`69`	`69`	`public class RpcController : IRpcController`
`70`	`70`	`{`
`71`	`71`	`private readonly ICredentialManager _credentialManager;`
`72`		`- private readonly ISettingsManager<CoderConnectSettings> _settingsManager;`
`73`	`72`
`74`	`73`	`private readonly RaiiSemaphoreSlim _operationLock = new(1, 1);`
`75`	`74`	`private Speaker<ClientMessage, ServiceMessage>? _speaker;`
`76`	`75`
`77`	`76`	`private readonly RaiiSemaphoreSlim _stateLock = new(1, 1);`
`78`	`77`	`private readonly RpcModel _state = new();`
`79`	`78`
`80`		`- public RpcController(ICredentialManager credentialManager, ISettingsManager<CoderConnectSettings> settingsManager)`
	`79`	`+ public RpcController(ICredentialManager credentialManager)`
`81`	`80`	`{`
`82`	`81`	`_credentialManager = credentialManager;`
`83`		`- _settingsManager = settingsManager;`
`84`	`82`	`}`
`85`	`83`
`86`	`84`	`public event EventHandler<RpcModel>? StateChanged;`
`@@ -158,7 +156,6 @@ public async Task StartVpn(CancellationToken ct = default)`
`158`	`156`	`using var _ = await AcquireOperationLockNowAsync();`
`159`	`157`	`AssertRpcConnected();`
`160`	`158`
`161`		`- var coderConnectSettings = await _settingsManager.Read(ct);`
`162`	`159`	`var credentials = _credentialManager.GetCachedCredentials();`
`163`	`160`	`if (credentials.State != CredentialState.Valid)`
`164`	`161`	`throw new RpcOperationException(`
`@@ -178,7 +175,6 @@ public async Task StartVpn(CancellationToken ct = default)`
`178`	`175`	`{`
`179`	`176`	`CoderUrl = credentials.CoderUrl?.ToString(),`
`180`	`177`	`ApiToken = credentials.ApiToken,`
`181`		`- TunnelUseSoftNetIsolation = coderConnectSettings.EnableCorporateVpnSupport,`
`182`	`178`	`},`
`183`	`179`	`}, ct);`
`184`	`180`	`}`