fix: stop vpn binary on startup failure (#150)

deansheather · web-flow · commit d7f4ac8dc965 · 2025-07-29T00:17:57.000+10:00
The vpn binary doesn't exit by itself on failure to avoid messing up RPC calls, so the parent process is expected to stop it.
diff --git a/Vpn.Service/Manager.cs b/Vpn.Service/Manager.cs
@@ -172,6 +172,10 @@ await _tunnelSupervisor.StartAsync(_config.TunnelBinaryPath, HandleTunnelRpcMess
                 if (reply.MsgCase != TunnelMessage.MsgOneofCase.Start)
                     throw new InvalidOperationException("Tunnel did not reply with a Start response");
 
+                // If the tunnel failed to start, stop the subprocess.
+                if (!reply.Start.Success)
+                    await _tunnelSupervisor.StopAsync(ct);
+
                 await BroadcastStatus(reply.Start.Success ? TunnelStatus.Started : TunnelStatus.Stopped, ct);
                 return reply.Start;
             }
