chore: change stale agent colour to yellow (#34)

ethanndickson · web-flow · commit e1ef77463770 · 2025-02-28T11:17:14.000Z
On the Mac app, we use Yellow when an agent's last handshake was longer
than 5 minutes ago. We should reserve red for a more fatal error, rather
than something that will show on every connection.
diff --git a/App/Converters/AgentStatusToColorConverter.cs b/App/Converters/AgentStatusToColorConverter.cs
@@ -9,6 +9,7 @@ namespace Coder.Desktop.App.Converters;
 public class AgentStatusToColorConverter : IValueConverter
 {
     private static readonly SolidColorBrush Green = new(Color.FromArgb(255, 52, 199, 89));
+    private static readonly SolidColorBrush Yellow = new(Color.FromArgb(255, 204, 1, 0));
     private static readonly SolidColorBrush Red = new(Color.FromArgb(255, 255, 59, 48));
     private static readonly SolidColorBrush Gray = new(Color.FromArgb(255, 142, 142, 147));
 
@@ -19,6 +20,7 @@ public object Convert(object value, Type targetType, object parameter, string la
         return status switch
         {
             AgentConnectionStatus.Green => Green,
+            AgentConnectionStatus.Yellow => Yellow,
             AgentConnectionStatus.Red => Red,
             _ => Gray,
         };
diff --git a/App/ViewModels/AgentViewModel.cs b/App/ViewModels/AgentViewModel.cs
@@ -9,6 +9,7 @@ namespace Coder.Desktop.App.ViewModels;
 public enum AgentConnectionStatus
 {
     Green,
+    Yellow,
     Red,
     Gray,
 }
diff --git a/App/ViewModels/TrayWindowViewModel.cs b/App/ViewModels/TrayWindowViewModel.cs
@@ -137,7 +137,7 @@ private void UpdateFromRpcModel(RpcModel rpcModel)
                 HostnameSuffix = fqdnSuffix,
                 ConnectionStatus = lastHandshakeAgo < TimeSpan.FromMinutes(5)
                     ? AgentConnectionStatus.Green
-                    : AgentConnectionStatus.Red,
+                    : AgentConnectionStatus.Yellow,
                 DashboardUrl = WorkspaceUri(coderUri, workspace?.Name),
             });
         }

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ namespace Coder.Desktop.App.Converters;`
`9`	`9`	`public class AgentStatusToColorConverter : IValueConverter`
`10`	`10`	`{`
`11`	`11`	`private static readonly SolidColorBrush Green = new(Color.FromArgb(255, 52, 199, 89));`
	`12`	`+ private static readonly SolidColorBrush Yellow = new(Color.FromArgb(255, 204, 1, 0));`
`12`	`13`	`private static readonly SolidColorBrush Red = new(Color.FromArgb(255, 255, 59, 48));`
`13`	`14`	`private static readonly SolidColorBrush Gray = new(Color.FromArgb(255, 142, 142, 147));`
`14`	`15`
`@@ -19,6 +20,7 @@ public object Convert(object value, Type targetType, object parameter, string la`
`19`	`20`	`return status switch`
`20`	`21`	`{`
`21`	`22`	`AgentConnectionStatus.Green => Green,`
	`23`	`+ AgentConnectionStatus.Yellow => Yellow,`
`22`	`24`	`AgentConnectionStatus.Red => Red,`
`23`	`25`	`_ => Gray,`
`24`	`26`	`};`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ namespace Coder.Desktop.App.ViewModels;`
`9`	`9`	`public enum AgentConnectionStatus`
`10`	`10`	`{`
`11`	`11`	`Green,`
	`12`	`+ Yellow,`
`12`	`13`	`Red,`
`13`	`14`	`Gray,`
`14`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ private void UpdateFromRpcModel(RpcModel rpcModel)`
`137`	`137`	`HostnameSuffix = fqdnSuffix,`
`138`	`138`	`ConnectionStatus = lastHandshakeAgo < TimeSpan.FromMinutes(5)`
`139`	`139`	`? AgentConnectionStatus.Green`
`140`		`- : AgentConnectionStatus.Red,`
	`140`	`+ : AgentConnectionStatus.Yellow,`
`141`	`141`	`DashboardUrl = WorkspaceUri(coderUri, workspace?.Name),`
`142`	`142`	`});`
`143`	`143`	`}`