Skip to content

Commit 2c8014b

Browse files
authored
fix: release notes formatting (#27)
- gh cli (gh release create) does not need \n and \r to be encoded as it should correctly interpret raw newlines from files. - also make zip available to download from draft release as it is easier to find
1 parent 950b3d0 commit 2c8014b

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/workflows/build.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,9 @@ jobs:
6969
VERSION="$(echo "$PROPERTIES" | grep "^version:" | cut -f2- -d ' ')"
7070
NAME="$(echo "$PROPERTIES" | grep "^group:" | cut -f2- -d ' ')"
7171
CHANGELOG="$(./gradlew getChangelog --unreleased --no-header --console=plain -q)"
72-
CHANGELOG="${CHANGELOG//'%'/'%25'}"
73-
CHANGELOG="${CHANGELOG//$'\n'/'%0A'}"
74-
CHANGELOG="${CHANGELOG//$'\r'/'%0D'}"
7572
echo "version=$VERSION" >> $GITHUB_OUTPUT
7673
echo "name=$NAME" >> $GITHUB_OUTPUT
77-
echo "changelog=$CHANGELOG" >> $GITHUB_OUTPUT
74+
echo "$CHANGELOG" > RELEASE_NOTES.md
7875
7976
# Run plugin build
8077
- name: Run Build
@@ -119,14 +116,19 @@ jobs:
119116
--jq '.[] | select(.draft == true) | .id' \
120117
| xargs -I '{}' gh api -X DELETE repos/${{ github.repository }}/releases/{}
121118
119+
- name: Download Build Artifacts
120+
uses: actions/download-artifact@v4
121+
with:
122+
name: release-artifacts
123+
path: artifacts/
124+
122125
# Create new release draft - which is not publicly visible and requires manual acceptance
123126
- name: Create Release Draft
124127
env:
125128
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
126129
run: |
127-
echo "${{ needs.build.outputs.changelog }}" > RELEASE_NOTES.md
128130
gh release create v${{ needs.build.outputs.version }} \
129-
--draft \
131+
--draft artifacts/* \
130132
--target ${GITHUB_REF_NAME} \
131133
--title "v${{ needs.build.outputs.version }}" \
132134
--notes-file RELEASE_NOTES.md

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy