chore: remove support for lenient moshi marshaller

fioan89 · fioan89 · commit 8a3a698123e1 · 2025-08-06T00:59:53.000+03:00
It is dangerous because it can allow dangerous operations in the plugin due to insufficient data that can be
interpreted as default state.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,6 @@
 ### Changed
 
 - URL validation is stricter in the connection screen and URI protocol handler
-- the http client has relaxed syntax rules when deserializing JSON responses
 - support for verbose logging a sanitized version of the REST API request and responses
 
 ## 0.6.0 - 2025-07-25
diff --git a/src/main/kotlin/com/coder/toolbox/sdk/CoderRestClient.kt b/src/main/kotlin/com/coder/toolbox/sdk/CoderRestClient.kt
@@ -139,7 +139,7 @@ open class CoderRestClient(
                 .addConverterFactory(
                     LoggingConverterFactory.wrap(
                         context,
-                        MoshiConverterFactory.create(moshi).asLenient()
+                        MoshiConverterFactory.create(moshi)
                     )
                 )
                 .build().create(CoderV2RestFacade::class.java)

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ open class CoderRestClient(`
`139`	`139`	`.addConverterFactory(`
`140`	`140`	`LoggingConverterFactory.wrap(`
`141`	`141`	`context,`
`142`		`- MoshiConverterFactory.create(moshi).asLenient()`
	`142`	`+ MoshiConverterFactory.create(moshi)`
`143`	`143`	`)`
`144`	`144`	`)`
`145`	`145`	`.build().create(CoderV2RestFacade::class.java)`