fix: misleading "No workspaces yet" during manual authentication (#104)

fioan89 · web-flow · commit db08dfafd8e3 · 2025-05-02T21:42:58.000+03:00
There is a brief moment between manual authentication and workspace poller initialization and execution where we see a "No workspaces yet" which is misleading. Instead, a loading indicator/message should be displayed. - resolves #103
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 ### Fixed
 
 - rendering glitches when a Workspace is stopped while SSH connection is alive
+- misleading message saying that there are no workspaces rendered during manual authentication
 
 ## 0.2.0 - 2025-04-24
 
diff --git a/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt b/src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
@@ -262,6 +262,7 @@ class CoderRemoteProvider(
             // start initialization with the new settings
             this@CoderRemoteProvider.client = restClient
             coderHeaderPage = NewEnvironmentPage(context, context.i18n.pnotr(restClient.url.toString()))
+            environments.showLoadingMessage()
             pollJob = poll(restClient, cli)
         }
     }
@@ -326,7 +327,14 @@ class CoderRemoteProvider(
         context.secrets.rememberMe = true
         this.client = client
         pollJob?.cancel()
+        environments.showLoadingMessage()
         pollJob = poll(client, cli)
         goToEnvironmentsPage()
     }
+
+    private fun MutableStateFlow<LoadableState<List<RemoteProviderEnvironment>>>.showLoadingMessage() {
+        this.update {
+            LoadableState.Loading
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,7 @@ class CoderRemoteProvider(`
`262`	`262`	`// start initialization with the new settings`
`263`	`263`	`this@CoderRemoteProvider.client = restClient`
`264`	`264`	`coderHeaderPage = NewEnvironmentPage(context, context.i18n.pnotr(restClient.url.toString()))`
	`265`	`+ environments.showLoadingMessage()`
`265`	`266`	`pollJob = poll(restClient, cli)`
`266`	`267`	`}`
`267`	`268`	`}`
`@@ -326,7 +327,14 @@ class CoderRemoteProvider(`
`326`	`327`	`context.secrets.rememberMe = true`
`327`	`328`	`this.client = client`
`328`	`329`	`pollJob?.cancel()`
	`330`	`+ environments.showLoadingMessage()`
`329`	`331`	`pollJob = poll(client, cli)`
`330`	`332`	`goToEnvironmentsPage()`
`331`	`333`	`}`
	`334`	`+`
	`335`	`+ private fun MutableStateFlow<LoadableState<List<RemoteProviderEnvironment>>>.showLoadingMessage() {`
	`336`	`+ this.update {`
	`337`	`+ LoadableState.Loading`
	`338`	`+ }`
	`339`	`+ }`
`332`	`340`	`}`