fix: go to previous step when connection fails (#77)

fioan89 · web-flow · commit e313f45b1ec1 · 2025-04-10T21:24:04.000+03:00
- happens when an error is encountered during connection (like
exceptions caused by an expired token)
- right now the auth wizard stays on the last step.
- with this changeset the auth steps reset to the initial sign in for
auto-connect, or it goes back one step back to the token input step for
manual authentication
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,10 @@
 
 - action buttons on the token input step were swapped to achieve better keyboard navigation 
 
+### Fixed
+
+- authorization wizard automatically goes to a previous screen when an error is encountered during connection to Coder deployment 
+
 ## 0.1.3 - 2025-04-09
 
 ### Fixed
diff --git a/src/main/kotlin/com/coder/toolbox/views/AuthWizardPage.kt b/src/main/kotlin/com/coder/toolbox/views/AuthWizardPage.kt
@@ -22,7 +22,7 @@ class AuthWizardPage(
 
     private val signInStep = SignInStep(context)
     private val tokenStep = TokenStep(context)
-    private val connectStep = ConnectStep(context, shouldAutoLogin, this::notify, onConnect)
+    private val connectStep = ConnectStep(context, shouldAutoLogin, this::notify, this::displaySteps, onConnect)
 
 
     /**
diff --git a/src/main/kotlin/com/coder/toolbox/views/ConnectStep.kt b/src/main/kotlin/com/coder/toolbox/views/ConnectStep.kt
@@ -27,6 +27,7 @@ class ConnectStep(
     private val context: CoderToolboxContext,
     private val shouldAutoLogin: StateFlow<Boolean>,
     private val notify: (String, Throwable) -> Unit,
+    private val refreshWizard: () -> Unit,
     private val onConnect: (
         client: CoderRestClient,
         cli: CoderCLIManager,
@@ -102,9 +103,13 @@ class ConnectStep(
             } catch (ex: CancellationException) {
                 if (ex.message != USER_HIT_THE_BACK_BUTTON) {
                     notify("Connection to ${url.host} was configured", ex)
+                    onBack()
+                    refreshWizard()
                 }
             } catch (ex: Exception) {
                 notify("Failed to configure ${url.host}", ex)
+                onBack()
+                refreshWizard()
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ class ConnectStep(`
`27`	`27`	`private val context: CoderToolboxContext,`
`28`	`28`	`private val shouldAutoLogin: StateFlow<Boolean>,`
`29`	`29`	`private val notify: (String, Throwable) -> Unit,`
	`30`	`+ private val refreshWizard: () -> Unit,`
`30`	`31`	`private val onConnect: (`
`31`	`32`	`client: CoderRestClient,`
`32`	`33`	`cli: CoderCLIManager,`
`@@ -102,9 +103,13 @@ class ConnectStep(`
`102`	`103`	`} catch (ex: CancellationException) {`
`103`	`104`	`if (ex.message != USER_HIT_THE_BACK_BUTTON) {`
`104`	`105`	`notify("Connection to ${url.host} was configured", ex)`
	`106`	`+ onBack()`
	`107`	`+ refreshWizard()`
`105`	`108`	`}`
`106`	`109`	`} catch (ex: Exception) {`
`107`	`110`	`notify("Failed to configure ${url.host}", ex)`
	`111`	`+ onBack()`
	`112`	`+ refreshWizard()`
`108`	`113`	`}`
`109`	`114`	`}`
`110`	`115`	`}`