suggestion

matifali · matifali · commit 1194fbd08ae9 · 2024-07-30T12:06:15.000+03:00
diff --git a/scripts/build.sh b/scripts/build.sh
@@ -1,12 +1,11 @@
 #!/usr/bin/env bash
 
-cd $(dirname "${BASH_SOURCE[0]}")
+cd "$(dirname "${BASH_SOURCE[0]}")"
 set -euxo pipefail
 
 # Set CI to false if not set
 CI=${CI:-false}
 
-
 # Get current architecture
 current=$(go env GOARCH)
 # Arhcitectures to build for
@@ -15,7 +14,7 @@ archs=(amd64 arm64 arm)
 # build for all architectures
 for arch in "${archs[@]}"; do
     echo "Building for $arch"
-    GOARCH=$arch GOOS=linux CGO_ENABLED=0 go build -ldflags "-s -w" -o ./coder-logstream-kube-$arch ../
+    GOARCH=$arch GOOS=linux CGO_ENABLED=0 go build -ldflags "-s -w" -o ./coder-logstream-kube-"$arch" ../
 done
 
 # We have to use docker buildx to tag multiple images with
@@ -25,21 +24,21 @@ BUILDER_EXISTS=$(docker buildx ls | grep $BUILDER_NAME || true)
 
 # If builder doesn't exist, create it
 if [ -z "$BUILDER_EXISTS" ]; then
-  echo "Creating dockerx builder $BUILDER_NAME..."
-  docker buildx create --use --platform=linux/arm64,linux/amd64,linux/arm/v7 --name $BUILDER_NAME
+    echo "Creating dockerx builder $BUILDER_NAME..."
+    docker buildx create --use --platform=linux/arm64,linux/amd64,linux/arm/v7 --name $BUILDER_NAME
 else
-  echo "Builder $BUILDER_NAME already exists. Using it."
+    echo "Builder $BUILDER_NAME already exists. Using it."
 fi
 
 # Ensure the builder is bootstrapped and ready to use
-docker buildx inspect --bootstrap &> /dev/null
+docker buildx inspect --bootstrap &>/dev/null
 
 # Build
 if [ "$CI" = "false" ]; then
-    docker buildx build --platform linux/$current -t coder-logstream-kube --load .
+    docker buildx build --platform linux/"$current" -t coder-logstream-kube --load .
 else
     VERSION=$(../scripts/version.sh)
     BASE=ghcr.io/coder/coder-logstream-kube
     IMAGE=$BASE:$VERSION
-    docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7 -t $IMAGE -t $BASE:latest --push.
-fi
+    docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v7 -t "$IMAGE" -t $BASE:latest --push.
+fi
