Enabled error response JSON body output

Russtopia · Russtopia · commit 362ddc7cab92 · 2020-07-30T10:02:20.000-07:00
diff --git a/internal/entclient/devurl.go b/internal/entclient/devurl.go
@@ -22,6 +22,7 @@ func (c Client) DelDevURL(envID, urlID string) error {
 	if err != nil {
 		return err
 	}
+	defer res.Body.Close()
 
 	if res.StatusCode != http.StatusOK {
 		return bodyError(res)
@@ -51,6 +52,7 @@ func (c Client) InsertDevURL(envID string, port int, name, access string) error
 	if err != nil {
 		return err
 	}
+	defer res.Body.Close()
 
 	if res.StatusCode != http.StatusOK {
 		return bodyError(res)
@@ -80,6 +82,7 @@ func (c Client) UpdateDevURL(envID, urlID string, port int, name, access string)
 	if err != nil {
 		return err
 	}
+	defer res.Body.Close()
 
 	if res.StatusCode != http.StatusOK {
 		return bodyError(res)
diff --git a/internal/entclient/error.go b/internal/entclient/error.go
@@ -8,7 +8,7 @@ import (
 )
 
 func bodyError(resp *http.Response) error {
-	byt, err := httputil.DumpResponse(resp, false)
+	byt, err := httputil.DumpResponse(resp, true)
 	if err != nil {
 		return xerrors.Errorf("dump response: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ func (c Client) DelDevURL(envID, urlID string) error {`
`22`	`22`	`if err != nil {`
`23`	`23`	`return err`
`24`	`24`	`}`
	`25`	`+ defer res.Body.Close()`
`25`	`26`
`26`	`27`	`if res.StatusCode != http.StatusOK {`
`27`	`28`	`return bodyError(res)`
`@@ -51,6 +52,7 @@ func (c Client) InsertDevURL(envID string, port int, name, access string) error`
`51`	`52`	`if err != nil {`
`52`	`53`	`return err`
`53`	`54`	`}`
	`55`	`+ defer res.Body.Close()`
`54`	`56`
`55`	`57`	`if res.StatusCode != http.StatusOK {`
`56`	`58`	`return bodyError(res)`
`@@ -80,6 +82,7 @@ func (c Client) UpdateDevURL(envID, urlID string, port int, name, access string)`
`80`	`82`	`if err != nil {`
`81`	`83`	`return err`
`82`	`84`	`}`
	`85`	`+ defer res.Body.Close()`
`83`	`86`
`84`	`87`	`if res.StatusCode != http.StatusOK {`
`85`	`88`	`return bodyError(res)`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`func bodyError(resp *http.Response) error {`
`11`		`- byt, err := httputil.DumpResponse(resp, false)`
	`11`	`+ byt, err := httputil.DumpResponse(resp, true)`
`12`	`12`	`if err != nil {`
`13`	`13`	`return xerrors.Errorf("dump response: %w", err)`
`14`	`14`	`}`