fix: use 0600 for private key in config-ssh (#235)

cmoog · web-flow · commit 63f6ec3944df · 2021-02-04T10:59:32.000-06:00
diff --git a/internal/cmd/configssh.go b/internal/cmd/configssh.go
@@ -81,6 +81,7 @@ func configSSH(configpath *string, remove *bool) func(cmd *cobra.Command, _ []st
 			if err != nil {
 				return xerrors.Errorf("write to ssh config file %q: %s", *configpath, err)
 			}
+			_ = os.Remove(privateKeyFilepath)
 
 			return nil
 		}
@@ -170,7 +171,7 @@ func writeSSHKey(ctx context.Context, client *coder.Client, privateKeyPath strin
 	if err != nil {
 		return err
 	}
-	return ioutil.WriteFile(privateKeyPath, []byte(key.PrivateKey), 0400)
+	return ioutil.WriteFile(privateKeyPath, []byte(key.PrivateKey), 0600)
 }
 
 func makeNewConfigs(userName string, envs []coderutil.EnvWithPool, privateKeyFilepath string) string {

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ func configSSH(configpath string, remove bool) func(cmd *cobra.Command, _ []st`
`81`	`81`	`if err != nil {`
`82`	`82`	`return xerrors.Errorf("write to ssh config file %q: %s", *configpath, err)`
`83`	`83`	`}`
	`84`	`+ _ = os.Remove(privateKeyFilepath)`
`84`	`85`
`85`	`86`	`return nil`
`86`	`87`	`}`
`@@ -170,7 +171,7 @@ func writeSSHKey(ctx context.Context, client *coder.Client, privateKeyPath strin`
`170`	`171`	`if err != nil {`
`171`	`172`	`return err`
`172`	`173`	`}`
`173`		`- return ioutil.WriteFile(privateKeyPath, []byte(key.PrivateKey), 0400)`
	`174`	`+ return ioutil.WriteFile(privateKeyPath, []byte(key.PrivateKey), 0600)`
`174`	`175`	`}`
`175`	`176`
`176`	`177`	`func makeNewConfigs(userName string, envs []coderutil.EnvWithPool, privateKeyFilepath string) string {`