fixup! fixup! Add tab:"omit" struct tag

cmoog · cmoog · commit bf466b07aaf9 · 2020-08-03T12:29:17.000-05:00
diff --git a/internal/entclient/me.go b/internal/entclient/me.go
@@ -6,12 +6,12 @@ import (
 
 // User describes a Coder user account
 type User struct {
-	ID        string    `json:"id" tab:"omit"`
+	ID        string    `json:"id" tab:"-"`
 	Email     string    `json:"email"`
 	Username  string    `json:"username"`
 	Name      string    `json:"name"`
 	CreatedAt time.Time `json:"created_at"`
-	UpdatedAt time.Time `json:"updated_at" tab:"omit"`
+	UpdatedAt time.Time `json:"updated_at" tab:"-"`
 }
 
 // Me gets the details of the authenticated user
diff --git a/internal/entclient/secrets.go b/internal/entclient/secrets.go
@@ -7,12 +7,12 @@ import (
 
 // Secret describes a Coder secret
 type Secret struct {
-	ID          string    `json:"id" tab:"omit"`
+	ID          string    `json:"id" tab:"-"`
 	Name        string    `json:"name"`
 	Value       string    `json:"value,omitempty"`
 	Description string    `json:"description"`
 	CreatedAt   time.Time `json:"created_at"`
-	UpdatedAt   time.Time `json:"updated_at" tab:"omit"`
+	UpdatedAt   time.Time `json:"updated_at" tab:"-"`
 }
 
 // Secrets gets all secrets owned by the authed user
diff --git a/internal/x/xtabwriter/tabwriter.go b/internal/x/xtabwriter/tabwriter.go
@@ -17,7 +17,7 @@ func NewWriter() *tabwriter.Writer {
 
 // StructValues tab delimits the values of a given struct.
 //
-// Tag a field `tab:"omit"` to hide it from output.
+// Tag a field `tab:"-"` to hide it from output.
 func StructValues(data interface{}) string {
 	v := reflect.ValueOf(data)
 	s := &strings.Builder{}
@@ -32,7 +32,7 @@ func StructValues(data interface{}) string {
 
 // StructFieldNames tab delimits the field names of a given struct.
 //
-// Tag a field `tab:"omit"` to hide it from output.
+// Tag a field `tab:"-"` to hide it from output.
 func StructFieldNames(data interface{}) string {
 	v := reflect.ValueOf(data)
 	s := &strings.Builder{}
@@ -47,5 +47,5 @@ func StructFieldNames(data interface{}) string {
 }
 
 func shouldHideField(f reflect.StructField) bool {
-	return f.Tag.Get(structFieldTagKey) == "omit"
+	return f.Tag.Get(structFieldTagKey) == "-"
 }
