chore: consistent empty loggers

coadler · coadler · commit cb58b46c3dcd · 2021-09-07T20:10:15.000-05:00
diff --git a/wsnet/dial.go b/wsnet/dial.go
@@ -16,9 +16,8 @@ import (
 	"golang.org/x/net/proxy"
 	"nhooyr.io/websocket"
 
-	"cdr.dev/slog"
-
 	"cdr.dev/coder-cli/coder-sdk"
+	"cdr.dev/slog"
 )
 
 // DialOptions are configurable options for a wsnet connection.
@@ -81,7 +80,9 @@ func Dial(ctx context.Context, conn net.Conn, options *DialOptions) (*Dialer, er
 		options = &DialOptions{}
 	}
 	if options.Log == nil {
-		options.Log = &slog.Logger{}
+		// This logger will log nothing.
+		log := slog.Make()
+		options.Log = &log
 	}
 	log := *options.Log
 	if options.ICEServers == nil {

Original file line number	Diff line number	Diff line change
`@@ -16,9 +16,8 @@ import (`
`16`	`16`	`"golang.org/x/net/proxy"`
`17`	`17`	`"nhooyr.io/websocket"`
`18`	`18`
`19`		`- "cdr.dev/slog"`
`20`		`-`
`21`	`19`	`"cdr.dev/coder-cli/coder-sdk"`
	`20`	`+ "cdr.dev/slog"`
`22`	`21`	`)`
`23`	`22`
`24`	`23`	`// DialOptions are configurable options for a wsnet connection.`
`@@ -81,7 +80,9 @@ func Dial(ctx context.Context, conn net.Conn, options DialOptions) (Dialer, er`
`81`	`80`	`options = &DialOptions{}`
`82`	`81`	`}`
`83`	`82`	`if options.Log == nil {`
`84`		`- options.Log = &slog.Logger{}`
	`83`	`+ // This logger will log nothing.`
	`84`	`+ log := slog.Make()`
	`85`	`+ options.Log = &log`
`85`	`86`	`}`
`86`	`87`	`log := *options.Log`
`87`	`88`	`if options.ICEServers == nil {`