fix: show correct min and max values in validation errors (#122)

mtojek · web-flow · commit 2f64d4c025fd · 2023-05-30T14:01:43.000+02:00
diff --git a/provider/parameter.go b/provider/parameter.go
@@ -438,10 +438,10 @@ func (v *Validation) Valid(typ, value string) error {
 			return fmt.Errorf("value %q is not a number", value)
 		}
 		if v.Min != nil && num < *v.Min {
-			return fmt.Errorf("value %d is less than the minimum %d", num, v.Min)
+			return fmt.Errorf("value %d is less than the minimum %d", num, *v.Min)
 		}
 		if v.Max != nil && num > *v.Max {
-			return fmt.Errorf("value %d is more than the maximum %d", num, v.Max)
+			return fmt.Errorf("value %d is more than the maximum %d", num, *v.Max)
 		}
 		if v.Monotonic != "" && v.Monotonic != ValidationMonotonicIncreasing && v.Monotonic != ValidationMonotonicDecreasing {
 			return fmt.Errorf("number monotonicity can be either %q or %q", ValidationMonotonicIncreasing, ValidationMonotonicDecreasing)
diff --git a/provider/parameter_test.go b/provider/parameter_test.go
@@ -499,13 +499,13 @@ func TestValueValidatesType(t *testing.T) {
 		Type:  "number",
 		Value: "0",
 		Min:   ptrNumber(1),
-		Error: regexp.MustCompile("is less than the minimum"),
+		Error: regexp.MustCompile("is less than the minimum 1"),
 	}, {
 		Name:  "NumberAboveMax",
 		Type:  "number",
 		Value: "2",
 		Max:   ptrNumber(1),
-		Error: regexp.MustCompile("is more than the maximum"),
+		Error: regexp.MustCompile("is more than the maximum 1"),
 	}, {
 		Name:  "InvalidBool",
 		Type:  "bool",

Original file line number	Diff line number	Diff line change
`@@ -438,10 +438,10 @@ func (v *Validation) Valid(typ, value string) error {`
`438`	`438`	`return fmt.Errorf("value %q is not a number", value)`
`439`	`439`	`}`
`440`	`440`	`if v.Min != nil && num < *v.Min {`
`441`		`- return fmt.Errorf("value %d is less than the minimum %d", num, v.Min)`
	`441`	`+ return fmt.Errorf("value %d is less than the minimum %d", num, *v.Min)`
`442`	`442`	`}`
`443`	`443`	`if v.Max != nil && num > *v.Max {`
`444`		`- return fmt.Errorf("value %d is more than the maximum %d", num, v.Max)`
	`444`	`+ return fmt.Errorf("value %d is more than the maximum %d", num, *v.Max)`
`445`	`445`	`}`
`446`	`446`	`if v.Monotonic != "" && v.Monotonic != ValidationMonotonicIncreasing && v.Monotonic != ValidationMonotonicDecreasing {`
`447`	`447`	`return fmt.Errorf("number monotonicity can be either %q or %q", ValidationMonotonicIncreasing, ValidationMonotonicDecreasing)`