add more validation tests

Emyrk · Emyrk · commit 6ee8b80682cc · 2025-04-30T14:37:34.000-05:00
diff --git a/provider/parameter_test.go b/provider/parameter_test.go
@@ -945,6 +945,15 @@ func TestParameterValidation(t *testing.T) {
 			Value:       "delta", // not in option set
 			ExpectError: regexp.MustCompile("Value must be a valid option"),
 		},
+		{
+			Name: "NumberNotInOptions",
+			Parameter: provider.Parameter{
+				Type:   "number",
+				Option: opts("1", "2", "3"),
+			},
+			Value:       "0", // not in option set
+			ExpectError: regexp.MustCompile("Value must be a valid option"),
+		},
 		{
 			Name: "NonUniqueOptionNames",
 			Parameter: provider.Parameter{
@@ -983,6 +992,55 @@ func TestParameterValidation(t *testing.T) {
 			Value:       "not-a-number",
 			ExpectError: regexp.MustCompile("Parameter value is not of type \"number\""),
 		},
+		{
+			Name: "NotListStringDefault",
+			Parameter: provider.Parameter{
+				Type:    "list(string)",
+				Default: "not-a-list",
+			},
+			ExpectError: regexp.MustCompile("not a valid list of strings"),
+		},
+		{
+			Name: "NotListStringDefault",
+			Parameter: provider.Parameter{
+				Type: "list(string)",
+			},
+			Value:       "not-a-list",
+			ExpectError: regexp.MustCompile("not a valid list of strings"),
+		},
+		{
+			Name: "DefaultListStringNotInOptions",
+			Parameter: provider.Parameter{
+				Type:     "list(string)",
+				Default:  `["red", "yellow", "black"]`,
+				Option:   opts("red", "blue", "green"),
+				FormType: provider.ParameterFormTypeMultiSelect,
+			},
+			ExpectError: regexp.MustCompile("is not a valid option, values \"yellow, black\" are missing from the options"),
+		},
+		{
+			Name: "ListStringNotInOptions",
+			Parameter: provider.Parameter{
+				Type:     "list(string)",
+				Default:  `["red"]`,
+				Option:   opts("red", "blue", "green"),
+				FormType: provider.ParameterFormTypeMultiSelect,
+			},
+			Value:       `["red", "yellow", "black"]`,
+			ExpectError: regexp.MustCompile("is not a valid option, values \"yellow, black\" are missing from the options"),
+		},
+		{
+			Name: "InvalidMiniumum",
+			Parameter: provider.Parameter{
+				Type:    "number",
+				Default: "5",
+				Validation: []provider.Validation{{
+					Min:   10,
+					Error: "must be greater than 10",
+				}},
+			},
+			ExpectError: regexp.MustCompile("must be greater than 10"),
+		},
 	} {
 		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
