feat: Add app support

kylecarbs · kylecarbs · commit e0bcc6a17fd2 · 2022-05-06T16:48:39.000Z
This adds what are presently named "devurls" in v1.
It seems this is a dated term, since this allows
much more than accessing applications via URL.

"coder open &lt;name&gt;" will launch any apps defined.
If in the web, it'll open either a web terminal or
port forward to the desired application. If in the terminal,
it'll open the browser, or launch the command over SSH.
diff --git a/docs/resources/app.md b/docs/resources/app.md
@@ -0,0 +1,65 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "coder_app Resource - terraform-provider-coder"
+subcategory: ""
+description: |-
+  Use this resource to define shortcuts to access applications in a workspace.
+---
+
+# coder_app (Resource)
+
+Use this resource to define shortcuts to access applications in a workspace.
+
+## Example Usage
+
+```terraform
+data "coder_workspace" "me" {}
+
+resource "coder_agent" "dev" {
+  os             = "linux"
+  arch           = "amd64"
+  dir            = "/workspace"
+  startup_script = <<EOF
+curl -fsSL https://code-server.dev/install.sh | sh
+code-server --auth none --port 13337
+EOF
+}
+
+resource "coder_app" "code-server" {
+  agent_id = coder_agent.dev.id
+  name     = "VS Code"
+  icon     = data.coder_workspace.me.access_url + "/icons/vscode.svg"
+  target   = "http://localhost:13337"
+}
+
+resource "coder_app" "vim" {
+  agent_id = coder_agent.dev.id
+  name     = "Vim"
+  icon     = data.coder_workspace.me.access_url + "/icons/vim.svg"
+  command  = "vim"
+}
+
+resource "coder_app" "intellij" {
+  agent_id = coder_agent.dev.id
+  icon     = data.coder_workspace.me.access_url + "/icons/intellij.svg"
+  name     = "JetBrains IntelliJ"
+  command  = "projector run"
+}
+```
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `agent_id` (String) The "id" property of a "coder_agent" resource to associate with.
+
+### Optional
+
+- `command` (String) A command to run in a terminal opening this app. In the web, this will open in a new tab. In the CLI, this will SSH and execute the command.
+- `icon` (String) A URL to an icon that will display in the dashboard. View built-in icons here: https://github.com/coder/coder/tree/main/site/static/icons. Use a built-in icon with `data.coder_workspace.me.access_url + "/icons/<path>"`.
+- `id` (String) The ID of this resource.
+- `name` (String) A display name to identify the app.
+- `target` (String) A URL to be proxied to from inside the workspace.
+
+
diff --git a/examples/resources/coder_app/resource.tf b/examples/resources/coder_app/resource.tf
@@ -0,0 +1,32 @@
+data "coder_workspace" "me" {}
+
+resource "coder_agent" "dev" {
+  os             = "linux"
+  arch           = "amd64"
+  dir            = "/workspace"
+  startup_script = <<EOF
+curl -fsSL https://code-server.dev/install.sh | sh
+code-server --auth none --port 13337
+EOF
+}
+
+resource "coder_app" "code-server" {
+  agent_id = coder_agent.dev.id
+  name     = "VS Code"
+  icon     = data.coder_workspace.me.access_url + "/icons/vscode.svg"
+  target   = "http://localhost:13337"
+}
+
+resource "coder_app" "vim" {
+  agent_id = coder_agent.dev.id
+  name     = "Vim"
+  icon     = data.coder_workspace.me.access_url + "/icons/vim.svg"
+  command  = "vim"
+}
+
+resource "coder_app" "intellij" {
+  agent_id = coder_agent.dev.id
+  icon     = data.coder_workspace.me.access_url + "/icons/intellij.svg"
+  name     = "JetBrains IntelliJ"
+  command  = "projector run"
+}
diff --git a/internal/provider/provider.go b/internal/provider/provider.go
@@ -89,6 +89,11 @@ func New() *schema.Provider {
 						id = uuid.NewString()
 					}
 					rd.SetId(id)
+					config, valid := i.(config)
+					if !valid {
+						return diag.Errorf("config was unexpected type %q", reflect.TypeOf(i).String())
+					}
+					rd.Set("access_url", config.URL.String())
 					return nil
 				},
 				Schema: map[string]*schema.Schema{
@@ -227,6 +232,63 @@ func New() *schema.Provider {
 					},
 				},
 			},
+			"coder_app": {
+				Description: "Use this resource to define shortcuts to access applications in a workspace.",
+				CreateContext: func(c context.Context, resourceData *schema.ResourceData, i interface{}) diag.Diagnostics {
+					resourceData.SetId(uuid.NewString())
+					return nil
+				},
+				ReadContext: func(c context.Context, resourceData *schema.ResourceData, i interface{}) diag.Diagnostics {
+					return nil
+				},
+				DeleteContext: func(ctx context.Context, rd *schema.ResourceData, i interface{}) diag.Diagnostics {
+					return nil
+				},
+				Schema: map[string]*schema.Schema{
+					"agent_id": {
+						Type:        schema.TypeString,
+						Description: `The "id" property of a "coder_agent" resource to associate with.`,
+						ForceNew:    true,
+						Required:    true,
+					},
+					"name": {
+						Type:        schema.TypeString,
+						Description: "A display name to identify the app.",
+						ForceNew:    true,
+						Optional:    true,
+					},
+					"icon": {
+						Type: schema.TypeString,
+						Description: "A URL to an icon that will display in the dashboard. View built-in " +
+							"icons here: https://github.com/coder/coder/tree/main/site/static/icons. Use a " +
+							"built-in icon with `data.coder_workspace.me.access_url + \"/icons/<path>\"`.",
+						ForceNew: true,
+						Optional: true,
+						ValidateFunc: func(i interface{}, s string) ([]string, []error) {
+							_, err := url.Parse(s)
+							if err != nil {
+								return nil, []error{err}
+							}
+							return nil, nil
+						},
+					},
+					"command": {
+						Type: schema.TypeString,
+						Description: "A command to run in a terminal opening this app. In the web, " +
+							"this will open in a new tab. In the CLI, this will SSH and execute the command.",
+						ConflictsWith: []string{"target"},
+						Optional:      true,
+						ForceNew:      true,
+					},
+					"target": {
+						Type:          schema.TypeString,
+						Description:   "A URL to be proxied to from inside the workspace.",
+						ForceNew:      true,
+						Optional:      true,
+						ConflictsWith: []string{"command"},
+					},
+				},
+			},
 		},
 	}
 }
diff --git a/internal/provider/provider_test.go b/internal/provider/provider_test.go
@@ -134,3 +134,47 @@ func TestAgentInstance(t *testing.T) {
 		}},
 	})
 }
+
+func TestApp(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		Providers: map[string]*schema.Provider{
+			"coder": provider.New(),
+		},
+		IsUnitTest: true,
+		Steps: []resource.TestStep{{
+			Config: `
+				provider "coder" {
+				}
+				resource "coder_agent" "dev" {
+					os = "linux"
+					arch = "amd64"
+				}
+				resource "coder_app" "code-server" {
+					agent_id = coder_agent.dev.id
+					name = "code-server"
+					icon = "builtin:vim"
+					target = "http://localhost:13337"
+				}
+				`,
+			Check: func(state *terraform.State) error {
+				require.Len(t, state.Modules, 1)
+				require.Len(t, state.Modules[0].Resources, 2)
+				resource := state.Modules[0].Resources["coder_app.code-server"]
+				require.NotNil(t, resource)
+				for _, key := range []string{
+					"agent_id",
+					"name",
+					"icon",
+					"target",
+				} {
+					value := resource.Primary.Attributes[key]
+					t.Logf("%q = %q", key, value)
+					require.NotNil(t, value)
+					require.Greater(t, len(value), 0)
+				}
+				return nil
+			},
+		}},
+	})
+}
