exploring an idea

Emyrk · Emyrk · commit f1a0fd5a68bd · 2025-04-29T10:44:57.000-05:00
diff --git a/provider/parameter_test.go b/provider/parameter_test.go
@@ -686,6 +686,183 @@ data "coder_parameter" "region" {
 	}
 }
 
+//nolint:paralleltest,tparallel // Parameters load values from env vars
+func TestParameterValidationEnforcement(t *testing.T) {
+	for _, tc := range []struct {
+		Name        string
+		Config      string
+		Value       string
+		ExpectError *regexp.Regexp
+		Check       func(state *terraform.ResourceState)
+	}{
+		// Empty
+		{
+			Name: "EmptyString",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "string"
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "",
+					"value":    "",
+					"optional": "false",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+		{
+			Name: "EmptyNumber",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "number"
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "",
+					"value":    "",
+					"optional": "false",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+		// EmptyWithOption
+		{
+			Name: "EmptyWithOption",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "number"
+				
+				option {	
+					name = "option"
+					value = "5"	
+				}
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "",
+					"value":    "",
+					"optional": "false",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+		// DefaultSet
+		{
+			Name: "DefaultSet",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "number"
+				default = "5"
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "5",
+					"value":    "5",
+					"optional": "true",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+		{
+			Name: "DefaultSetInOption",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "number"
+				default = "5"
+				option {	
+					name = "option"
+					value = "5"	
+				}
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "5",
+					"value":    "5",
+					"optional": "true",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+		{
+			Name: "DefaultSetOutOption",
+			Config: `
+			data "coder_parameter" "parameter" {
+				name = "parameter"
+				type = "number"
+				default = "2"
+				option {	
+					name = "option"
+					value = "5"	
+				}
+			}
+`,
+			ExpectError: nil,
+			Check: func(state *terraform.ResourceState) {
+				attrs := state.Primary.Attributes
+				for key, value := range map[string]interface{}{
+					"default":  "5",
+					"value":    "5",
+					"optional": "true",
+				} {
+					require.Equal(t, value, attrs[key])
+				}
+			},
+		},
+	} {
+		tc := tc
+		//nolint:paralleltest,tparallel // Parameters load values from env vars
+		t.Run(tc.Name, func(t *testing.T) {
+			if tc.Value != "" {
+				t.Setenv(provider.ParameterEnvironmentVariable("parameter"), tc.Value)
+			}
+			resource.Test(t, resource.TestCase{
+				ProviderFactories: coderFactory(),
+				IsUnitTest:        true,
+				Steps: []resource.TestStep{{
+					Config:      tc.Config,
+					ExpectError: tc.ExpectError,
+					Check: func(state *terraform.State) error {
+						require.Len(t, state.Modules, 1)
+						require.Len(t, state.Modules[0].Resources, 1)
+						param := state.Modules[0].Resources["data.coder_parameter.parameter"]
+						require.NotNil(t, param)
+						if tc.Check != nil {
+							tc.Check(param)
+						}
+						return nil
+					},
+				}},
+			})
+		})
+	}
+}
+
 func TestValueValidatesType(t *testing.T) {
 	t.Parallel()
 	for _, tc := range []struct {
@@ -798,6 +975,25 @@ func TestValueValidatesType(t *testing.T) {
 		Value:       `[]`,
 		MinDisabled: true,
 		MaxDisabled: true,
+	}, {
+		Name:        "ValidListOfStrings",
+		Type:        "list(string)",
+		Value:       `["first","second","third"]`,
+		MinDisabled: true,
+		MaxDisabled: true,
+	}, {
+		Name:        "InvalidListOfStrings",
+		Type:        "list(string)",
+		Value:       `["first","second","third"`,
+		MinDisabled: true,
+		MaxDisabled: true,
+		Error:       regexp.MustCompile("is not valid list of strings"),
+	}, {
+		Name:        "EmptyListOfStrings",
+		Type:        "list(string)",
+		Value:       `[]`,
+		MinDisabled: true,
+		MaxDisabled: true,
 	}} {
 		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
diff --git a/provider/table_test.go b/provider/table_test.go
@@ -0,0 +1,56 @@
+package provider_test
+
+import (
+	"strconv"
+	"strings"
+	"testing"
+)
+
+func TestMDtable(t *testing.T) {
+	// Copy and paste the table to https://www.tablesgenerator.com/markdown_tables for easier editing
+	table := strings.TrimSpace(`
+| Name             | Type          | Input Value | Default   | Options | Validation | -> | Output Value | Optional | Error |
+|------------------|---------------|-------------|-----------|---------|------------|----|--------------|----------|-------|
+| Empty            | string,number | undefined   | undefined |         | undefined  |    | ""           | false    | -     |
+| EmptyWithOptions | number        | undefined   | undefined |         | undefined  |    | ""           | false    | -     |
+| DefaultSet       | number        | undefined   | 5         |         | undefined  |    | 5            | true     | -     |
+`)
+
+	type row struct {
+		Name        string
+		Types       []string
+		InputValue  string
+		Default     string
+		Options     string
+		Validation  string
+		OutputValue string
+		Optional    bool
+		Error       string
+	}
+
+	rows := make([]row, 0)
+	lines := strings.Split(table, "\n")
+	for _, line := range lines[2:] {
+		columns := strings.Split(line, "|")
+		columns = columns[1 : len(columns)-2]
+		for i := range columns {
+			columns[i] = strings.TrimSpace(columns[i])
+		}
+
+		optional, err := strconv.ParseBool(columns[8])
+		if err != nil {
+			t.Fatalf("failed to parse optional column %q: %v", columns[8], err)
+		}
+		rows = append(rows, row{
+			Name:        columns[0],
+			Types:       strings.Split(columns[1], ","),
+			InputValue:  columns[2],
+			Default:     columns[3],
+			Options:     columns[4],
+			Validation:  columns[5],
+			OutputValue: columns[7],
+			Optional:    optional,
+			Error:       columns[9],
+		})
+	}
+}
